Add .size() to the SectionList object, returns the number of sections in the list#3520
Conversation
…ns in the list * used `.size()` to match what is in Vector() * Took the opportunity to public declarations in headers
|
✔️ aaa1001 -> artifacts URL |
|
✔️ cc0e8f9 -> artifacts URL |
|
✔️ aaa1001 -> Azure artifacts URL |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3520 +/- ##
=======================================
Coverage 68.44% 68.45%
=======================================
Files 683 683
Lines 116608 116611 +3
=======================================
+ Hits 79816 79827 +11
+ Misses 36792 36784 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JCGoran
left a comment
There was a problem hiding this comment.
Looks good, some minor comments.
|
|
✔️ 507b86d -> artifacts URL |
|
✔️ 507b86d -> Azure artifacts URL |
|
@JCGoran I don't have merge permission; can you do it? |
|
Are we sure that this is correct? In particular, normally when we iterate over a list, we also check to see if the sections are still active (have non-null prop). They'd get a null prop if they were deleted from HOC (which doesn't actually remove them from section lists that may contain them). |
If that's the case, the previous python nrn/src/nrnpython/nrnpy_hoc.cpp Line 1640 in b1843f7 I guess it comes down to the desired semantics: should list items that have a null prop be counted? |
@ramcdougal responded here: #3522 |
.size()to match what is in Vector()