Skip to content

Add NMODL warning if a FUNCTION does not have a return statement #3404

Merged
JCGoran merged 4 commits into
masterfrom
jelic/add_nmodl_warning
May 8, 2025
Merged

Add NMODL warning if a FUNCTION does not have a return statement #3404
JCGoran merged 4 commits into
masterfrom
jelic/add_nmodl_warning

Conversation

@JCGoran

@JCGoran JCGoran commented May 6, 2025

Copy link
Copy Markdown
Collaborator

This adds warnings when processing mod files with NMODL in two scenarios:

  • if a FUNCTION with a missing return statement doesn't have a VERBATIM block, then we can definitely say the function is missing a return statement
  • if a FUNCTION with a missing return statement does have a VERBATIM block, then we still warn, since the user could have forgotten it there as well

@azure-pipelines

Copy link
Copy Markdown

✔️ 4aa8611 -> Azure artifacts URL

@codecov

codecov Bot commented May 6, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.35%. Comparing base (d5bfd72) to head (fb26612).
⚠️ Report is 86 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3404   +/-   ##
=======================================
  Coverage   68.34%   68.35%           
=======================================
  Files         682      682           
  Lines      116428   116459   +31     
=======================================
+ Hits        79578    79609   +31     
  Misses      36850    36850           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JCGoran JCGoran marked this pull request as ready for review May 6, 2025 18:57
@JCGoran JCGoran requested review from nrnhines and ramcdougal May 6, 2025 18:57
@sonarqubecloud

sonarqubecloud Bot commented May 7, 2025

Copy link
Copy Markdown

@azure-pipelines

Copy link
Copy Markdown

✔️ fb26612 -> Azure artifacts URL

@JCGoran JCGoran merged commit f43ea06 into master May 8, 2025
@JCGoran JCGoran deleted the jelic/add_nmodl_warning branch May 8, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants