Skip to content

Update rxd.MultipleGeometry to support 3D and hybrid models.#3389

Merged
ramcdougal merged 4 commits into
masterfrom
rxd_multi_geom
May 15, 2025
Merged

Update rxd.MultipleGeometry to support 3D and hybrid models.#3389
ramcdougal merged 4 commits into
masterfrom
rxd_multi_geom

Conversation

@adamjhn

@adamjhn adamjhn commented Apr 20, 2025

Copy link
Copy Markdown
Member

Fixes the problem from the forum post on Multiple geometries and rxd; https://www.neuron.yale.edu/phpBB/viewtopic.php?t=4742

@adamjhn adamjhn added the rxd reaction-diffusion label Apr 20, 2025
@adamjhn adamjhn requested a review from ramcdougal April 20, 2025 14:57
@azure-pipelines

azure-pipelines Bot commented Apr 20, 2025

Copy link
Copy Markdown

✔️ 49dc129 -> Azure artifacts URL

@codecov

codecov Bot commented Apr 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.35%. Comparing base (d5bfd72) to head (8dc69d0).
⚠️ Report is 89 commits behind head on master.

Files with missing lines Patch % Lines
share/lib/python/neuron/rxd/geometry.py 82.75% 5 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3389   +/-   ##
=======================================
  Coverage   68.34%   68.35%           
=======================================
  Files         682      682           
  Lines      116428   116457   +29     
=======================================
+ Hits        79578    79602   +24     
- Misses      36850    36855    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ramcdougal
ramcdougal requested changes Apr 29, 2025
View reviewed changes
Comment thread share/lib/python/neuron/rxd/geometry.py
Comment thread share/lib/python/neuron/rxd/geometry.py Outdated
Comment thread share/lib/python/neuron/rxd/geometry.py Outdated
Comment thread test/rxd/3d/test_multigeometry.py Outdated
Comment thread share/lib/python/neuron/rxd/geometry.py Outdated
@ramcdougal ramcdougal enabled auto-merge (squash) April 29, 2025 15:11
@ramcdougal ramcdougal disabled auto-merge April 29, 2025 15:14
@azure-pipelines

azure-pipelines Bot commented Apr 29, 2025

Copy link
Copy Markdown

✔️ c86e1e5 -> Azure artifacts URL

@sonarqubecloud

sonarqubecloud Bot commented May 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@azure-pipelines

azure-pipelines Bot commented May 6, 2025

Copy link
Copy Markdown

✔️ 8dc69d0 -> Azure artifacts URL

@ramcdougal ramcdougal merged commit 765e9c8 into master May 15, 2025
@ramcdougal ramcdougal deleted the rxd_multi_geom branch May 15, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramcdougal ramcdougal ramcdougal approved these changes

Assignees

No one assigned

Labels

rxd reaction-diffusion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamjhn @ramcdougal