Use GitHub actions for MacOS ARM wheels#3382
Merged
Merged
Conversation
|
✔️ 5e39cba -> Azure artifacts URL |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3382 +/- ##
=======================================
Coverage 68.36% 68.36%
=======================================
Files 682 682
Lines 116465 116465
=======================================
Hits 79619 79619
Misses 36846 36846 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
✔️ 55c7bd1 -> artifacts URL |
|
✔️ 55c7bd1 -> Azure artifacts URL |
added 23 commits
May 7, 2025 12:36
Contributor
|
✔️ 1ab60c1 -> artifacts URL |
Contributor
|
✔️ 2b84f50 -> artifacts URL |
Contributor
|
✔️ 5b4790e -> artifacts URL |
Contributor
|
✔️ a71b286 -> artifacts URL |
JCGoran
commented
May 7, 2025
Contributor
|
✔️ 844d74e -> artifacts URL |
|
✔️ 844d74e -> Azure artifacts URL |
nrnhines
approved these changes
May 7, 2025
|
Contributor
|
✔️ 631a834 -> artifacts URL |
|
✔️ 631a834 -> Azure artifacts URL |
Member
|
Glad that to see this milestone ! 🎉🙌🏻 |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Basically a spin-off of #3321, but only restricted to ARM MacOS so we see that the workflows actually work as intended, later we can easily expand them to accommodate other platforms and Python versions.
Fixes #2359.
Changes
wheels-template.yml)pypi-upload-template.yml)wheels-ci.ymlfor running the CI on PRs and main branch (for min and max Python versions only!)wheels-nightly.ymluploading nightly releases. Once this works, I can introduce a workflow for the stable releases as wellbuild_wheels.bashThis means that the workflow for building wheels is now entirely reusable, and takes the following inputs:
change_name.pyscript is called appropriately (otherwise the wheel will be calledneuron_nightlyinstead ofneuron)optimize_rxd: for nightly and (future!) releases we use optimization level 2, while for CI (both PRs and main branch) we use opt level 0. This flag could admittedly be more general to take any env variables, but then one needs to parse it with something (should input be comma-separated? JSON? Lots of ways to tackle this...), so I opted for a simple boolean flag instead.