Fix handling of hh.mod when using coreNEURON#3301
Merged
Merged
Conversation
|
|
✔️ 12b619f -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3301 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 571 571
Lines 111055 111055
=======================================
+ Hits 74487 74488 +1
+ Misses 36568 36567 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3000.
All mod files are first copied to the build dir (unless it's
hh.modin coreNEURON mode, in which case we modify the file) at configure time, then at build-time those files are actually converted tocppfiles and compiled.Unfortunately, one cannot use
fileat build-time, so we need to useadd_custom_commandwith an external util (likesed) for replacing_reg()with_reg_()in the generated cpp files (since those are actually generated only at build-time). I also opted for usingcmake -E copyetc. for modifying the file because 1)sed '[pattern]' [input] > [output]does not work, and 2) the default MacOSsedhas some idiosyncrasies compared to GNUsedthat I wanted to avoid.