Skip to content

Support multicompartment reactions with source & destination in the ecs.#3296

Merged
ramcdougal merged 6 commits into
masterfrom
rxd_ecs_multi
May 15, 2025
Merged

Support multicompartment reactions with source & destination in the ecs.#3296
ramcdougal merged 6 commits into
masterfrom
rxd_ecs_multi

Conversation

@adamjhn

@adamjhn adamjhn commented Dec 18, 2024

Copy link
Copy Markdown
Member

No description provided.

@adamjhn adamjhn added the rxd reaction-diffusion label Dec 18, 2024
@azure-pipelines

azure-pipelines Bot commented Dec 18, 2024

Copy link
Copy Markdown

✔️ 335e1e5 -> Azure artifacts URL

@codecov

codecov Bot commented Dec 18, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.35%. Comparing base (d5bfd72) to head (140b974).
⚠️ Report is 89 commits behind head on master.

Files with missing lines Patch % Lines
share/lib/python/neuron/rxd/generalizedReaction.py 85.71% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3296   +/-   ##
=======================================
  Coverage   68.34%   68.35%           
=======================================
  Files         682      682           
  Lines      116428   116448   +20     
=======================================
+ Hits        79578    79596   +18     
- Misses      36850    36852    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarqubecloud

sonarqubecloud Bot commented Dec 19, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@azure-pipelines

azure-pipelines Bot commented Dec 19, 2024

Copy link
Copy Markdown

✔️ 8e9472e -> Azure artifacts URL

@bbpbuildbot

bbpbuildbot commented Dec 19, 2024

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #240398 (:no_entry:) have been uploaded here!

Status and direct links:

@adamjhn adamjhn requested a review from ramcdougal December 28, 2024 11:03
@sonarqubecloud

sonarqubecloud Bot commented Mar 25, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@azure-pipelines

azure-pipelines Bot commented Mar 25, 2025

Copy link
Copy Markdown

✔️ 0ad87c8 -> Azure artifacts URL

ramcdougal
ramcdougal requested changes Apr 29, 2025
View reviewed changes

@ramcdougal ramcdougal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main question here is the one about what happens if some is ecs but not both sides?

Comment thread share/lib/python/neuron/rxd/generalizedReaction.py Outdated
Comment thread share/lib/python/neuron/rxd/generalizedReaction.py
@sonarqubecloud

sonarqubecloud Bot commented May 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@azure-pipelines

azure-pipelines Bot commented May 6, 2025

Copy link
Copy Markdown

✔️ 140b974 -> Azure artifacts URL

@ramcdougal ramcdougal merged commit 0de1325 into master May 15, 2025
@ramcdougal ramcdougal deleted the rxd_ecs_multi branch May 15, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramcdougal ramcdougal ramcdougal approved these changes

Assignees

No one assigned

Labels

rxd reaction-diffusion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamjhn @bbpbuildbot @ramcdougal