Skip to content

Int replaced by floor to accept negative coordinates.#3264

Merged
ramcdougal merged 6 commits into
masterfrom
ceciliaromaro-patch-1
Dec 3, 2024
Merged

Int replaced by floor to accept negative coordinates.#3264
ramcdougal merged 6 commits into
masterfrom
ceciliaromaro-patch-1

Conversation

@ceciliaromaro

Copy link
Copy Markdown
Contributor

No description provided.

@ramcdougal ramcdougal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this; please remove the one comment and then it should be good.

Comment thread share/lib/python/neuron/rxd/node.py Outdated

@ramcdougal ramcdougal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a test.

Comment thread share/lib/python/neuron/rxd/node.py
@ramcdougal ramcdougal added this to the Release v9.0 milestone Dec 2, 2024
@azure-pipelines

Copy link
Copy Markdown

✔️ 6347c0b -> Azure artifacts URL

@codecov

codecov Bot commented Dec 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (5fe797a) to head (a24c547).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3264   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files         571      571           
  Lines      111095   111096    +1     
=======================================
+ Hits        74521    74522    +1     
  Misses      36574    36574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@sonarqubecloud

sonarqubecloud Bot commented Dec 2, 2024

Copy link
Copy Markdown

@azure-pipelines

Copy link
Copy Markdown

✔️ a24c547 -> Azure artifacts URL

@ramcdougal ramcdougal merged commit 95b14c9 into master Dec 3, 2024
@ramcdougal ramcdougal deleted the ceciliaromaro-patch-1 branch December 3, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants