Fix leaks in get_endian_character.#3257
Merged
Merged
Conversation
The facts are: * `PyImport_ImportModule` returns a new reference [1]. * `PyObject_GetAttrString` returns a new referece [2]. * `Py2NRNString::as_ascii` doesn't steal. Therefore, in both cases, we create a new reference without ever calling DECREF. [1]: https://docs.python.org/3.12/c-api/import.html#c.PyImport_ImportModule
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3257 +/- ##
=======================================
Coverage 67.09% 67.09%
=======================================
Files 570 570
Lines 111082 111082
=======================================
Hits 74525 74525
Misses 36557 36557 ☔ View full report in Codecov by Sentry. |
|
✔️ 9d0a6ce -> Azure artifacts URL |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The facts are:
PyImport_ImportModulereturns a new reference 1.PyObject_GetAttrStringreturns a new referece 2.Py2NRNString::as_asciidoesn't steal.Therefore, in both cases, we create a new reference without ever calling DECREF.