Fix leak in pysec_children and pysec_subtree.#3255
Merged
Conversation
The leak happens when and error occurs in the `*1` "helper" function. In that case the `sl` (created in the top-level function) isn't DECREFed, and also not returned. Therefore, it's leaked. In the first case this is fixed by inlining the helper function. In the second case, we check if the helper returns a nullptr and if not we return the new reference to the newly created list (by using `release().ptr()`). Note, that on the error path the `sl` will be cleaned up due to RAII semantics.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3255 +/- ##
==========================================
+ Coverage 67.07% 67.09% +0.01%
==========================================
Files 570 570
Lines 111066 111069 +3
==========================================
+ Hits 74502 74517 +15
+ Misses 36564 36552 -12 ☔ View full report in Codecov by Sentry. |
|
✔️ 804b8fd -> Azure artifacts URL |
Collaborator
alkino
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The leak happens when an error occurs in the
*1helper functions. Inthat case the
sl(created in the top-level function under the nameresult)isn't DECREFed, and also not returned. Therefore, it's leaked.
In the first case this is fixed by inlining the helper function.
In the second case, we check if the helper returns a
nullptrand if notwe return the new reference to the newly created list (by using
release().ptr()). Note, that on the error path theslwill becleaned up due to RAII semantics.