More doc elaboration on interaction of Shape, define_shape, and diam.#3187
Merged
Conversation
ramcdougal
reviewed
Nov 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3187 +/- ##
=======================================
Coverage 67.04% 67.04%
=======================================
Files 571 571
Lines 111269 111269
=======================================
Hits 74604 74604
Misses 36665 36665 ☔ View full report in Codecov by Sentry. |
|
✔️ f886ba5 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
|
✔️ 4fabae1 -> Azure artifacts URL |
Collaborator
1uc
approved these changes
Nov 18, 2024
1uc
left a comment
Collaborator
There was a problem hiding this comment.
Useful and easy to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3171