Skip to content

Remove deprecated python 3.8#3108

Merged
alkino merged 5 commits into
masterfrom
cornu/remove_deprecated_python_38
Nov 13, 2024
Merged

Remove deprecated python 3.8#3108
alkino merged 5 commits into
masterfrom
cornu/remove_deprecated_python_38

Conversation

@alkino

@alkino alkino commented Oct 2, 2024

Copy link
Copy Markdown
Member

No description provided.

@azure-pipelines

Copy link
Copy Markdown

✔️ 4e2d2a4 -> Azure artifacts URL

@codecov

codecov Bot commented Oct 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (1e95ecc) to head (f887ea2).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3108   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files         569      569           
  Lines      111206   111206           
=======================================
  Hits        74592    74592           
  Misses      36614    36614           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@alkino alkino marked this pull request as ready for review October 4, 2024 07:36
Comment thread docs/install/python_wheels.md Outdated
@azure-pipelines

Copy link
Copy Markdown

✔️ d006dec -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@azure-pipelines

Copy link
Copy Markdown

✔️ d818938 -> Azure artifacts URL

@JCGoran JCGoran left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.8 is officially EOL as of today, we can merge this.

@1uc

1uc commented Nov 1, 2024

Copy link
Copy Markdown
Collaborator

Is there anything we're currently interested in that's failing only for Python 3.8? If not, I'd say continue to check until it breaks.

@JCGoran

JCGoran commented Nov 11, 2024

Copy link
Copy Markdown
Collaborator

Not sure if related, but CircleCI fails on 3.8: https://app.circleci.com/pipelines/github/neuronsimulator/nrn/9697/workflows/fabca25f-f7da-4e81-b0f3-bef12f3bf368/jobs/4732
If we try 3.9, it works: https://app.circleci.com/pipelines/github/neuronsimulator/nrn/9714/workflows/fafc7f8d-9aa2-4638-98ab-8d618269d670/jobs/4736 (from this PR: #3197; also tried with RDMAV_FORK_SAFE=1, but it didn't do anything on 3.8).

I haven't found any mention of 3.8 being an issue on CircleCI, so it could just be a coincidence, but having one less Python version to support is always nice.

@sonarqubecloud

Copy link
Copy Markdown

@azure-pipelines

Copy link
Copy Markdown

✔️ f887ea2 -> Azure artifacts URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants