Remove deprecated python 3.8#3108
Conversation
|
✔️ 4e2d2a4 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3108 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 569 569
Lines 111206 111206
=======================================
Hits 74592 74592
Misses 36614 36614 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
✔️ d006dec -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
✔️ d818938 -> Azure artifacts URL |
JCGoran
left a comment
There was a problem hiding this comment.
3.8 is officially EOL as of today, we can merge this.
|
Is there anything we're currently interested in that's failing only for Python 3.8? If not, I'd say continue to check until it breaks. |
|
Not sure if related, but CircleCI fails on 3.8: https://app.circleci.com/pipelines/github/neuronsimulator/nrn/9697/workflows/fabca25f-f7da-4e81-b0f3-bef12f3bf368/jobs/4732 I haven't found any mention of 3.8 being an issue on CircleCI, so it could just be a coincidence, but having one less Python version to support is always nice. |
|
|
✔️ f887ea2 -> Azure artifacts URL |



No description provided.