Skip to content

Code change for ion and ion style semantics. Unlimited numbers.#3097

Merged
nrnhines merged 34 commits into
masterfrom
hines/ions-unlimited-semantics
Oct 25, 2024
Merged

Code change for ion and ion style semantics. Unlimited numbers.#3097
nrnhines merged 34 commits into
masterfrom
hines/ions-unlimited-semantics

Conversation

@nrnhines

@nrnhines nrnhines commented Sep 26, 2024

Copy link
Copy Markdown
Member

Ion and ion style semantics code change allows max_int number/2 of ion types.

wthun and others added 26 commits August 22, 2024 14:41
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
@azure-pipelines

Copy link
Copy Markdown

✔️ aceb0c5 -> Azure artifacts URL

@azure-pipelines

Copy link
Copy Markdown

✔️ 7223c0c -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Base automatically changed from hines/ions-unlimited to master October 1, 2024 14:37
@azure-pipelines

Copy link
Copy Markdown

✔️ 3e3358a -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@azure-pipelines

Copy link
Copy Markdown

✔️ bc44c53 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Comment thread src/coreneuron/mechanism/register_mech.cpp
@nrnhines nrnhines requested review from 1uc and pramodk October 24, 2024 00:03
@1uc

1uc commented Oct 24, 2024

Copy link
Copy Markdown
Collaborator

The CI failure isn't obviously benign, i.e. a timeout or similar; but it's also hard to imagine that it's related.

>           raise Exception("max diff {} > {}".format(max_diff, tolerance))
E           Exception: max diff 5.088799056284889e-08 > 5e-08

@1uc 1uc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

Comment thread src/nrnoc/init.cpp Outdated
@sonarqubecloud

Copy link
Copy Markdown

@azure-pipelines

Copy link
Copy Markdown

✔️ b6f9307 -> Azure artifacts URL

@codecov

codecov Bot commented Oct 24, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.18%. Comparing base (13e183b) to head (b6f9307).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3097   +/-   ##
=======================================
  Coverage   67.18%   67.18%           
=======================================
  Files         572      573    +1     
  Lines      111399   111408    +9     
=======================================
+ Hits        74846    74854    +8     
- Misses      36553    36554    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nrnhines nrnhines merged commit cd7ac7d into master Oct 25, 2024
@nrnhines nrnhines deleted the hines/ions-unlimited-semantics branch October 25, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants