Update docs for TABLE statement#2885
Merged
Merged
Conversation
|
✔️ e122c18 -> Azure artifacts URL |
1uc
reviewed
May 28, 2024
| which specifies that the tables are to be used (1, default) or not used (0). | ||
|
|
||
| With usetable_suffix = 0, when the procedure is called it ignores the tables | ||
| With ``usetable_<suffix> = 0``, when the procedure is called it ignores the tables |
Collaborator
There was a problem hiding this comment.
Suggested change
| With ``usetable_<suffix> = 0``, when the procedure is called it ignores the tables | |
| With ``usetable_<suffix> == 0``, when the procedure is called it ignores the tables |
1uc
reviewed
May 28, 2024
|
|
||
| With usetable_suffix = 1, when the procedure is called, the | ||
| arg value is used to assign values to the "variables" by looking them up | ||
| With ``usetable_<suffix> = 1``, when the procedure is called, the |
Collaborator
There was a problem hiding this comment.
Suggested change
| With ``usetable_<suffix> = 1``, when the procedure is called, the | |
| With ``usetable_<suffix> == 1``, when the procedure is called, the |
1uc
reviewed
May 28, 2024
| is saved. If the tables are out of date (a "dependency" has a different | ||
| is saved. If the tables are out of date (any of the ``dependencies`` has a different | ||
| value from its value the last time the tables were constructed) or have never | ||
| been created, the tables are created. |
Collaborator
There was a problem hiding this comment.
Could be split into two sentences:
A table is considered out-of-date if any of the ``dependencies`` has changed its value since the last time the table was constructed. If the table is out-of-date or has never been constructed it's (re-)created.
Though it might not be helpful.
1uc
reviewed
May 28, 2024
| time than an interpolated table lookup. | ||
|
|
||
| Also note that for any argument value outside of the interpolation range, | ||
| the returned value of a function with a TABLE will always be the value at |
Collaborator
There was a problem hiding this comment.
I think only if the table is used will it clamp.
1uc
reviewed
May 28, 2024
|
|
||
| Also note that for any argument value outside of the interpolation range, | ||
| the returned value of a function with a TABLE will always be the value at | ||
| the boundary (value at ``lowest`` if argument value is smaller than ``lowest``, |
Collaborator
There was a problem hiding this comment.
Suggested change
| the boundary (value at ``lowest`` if argument value is smaller than ``lowest``, | |
| the boundary, i.e. the value at ``lowest`` if argument value is smaller than ``lowest``, or the |
A math formula might be more effective.
1uc
reviewed
May 28, 2024
| Also note that for any argument value outside of the interpolation range, | ||
| the returned value of a function with a TABLE will always be the value at | ||
| the boundary (value at ``lowest`` if argument value is smaller than ``lowest``, | ||
| value at ``highest`` if argument value is larger than ``highest``). |
Collaborator
There was a problem hiding this comment.
Suggested change
| value at ``highest`` if argument value is larger than ``highest``). | |
| value at ``highest`` if argument value is larger than ``highest``. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2885 +/- ##
==========================================
+ Coverage 67.20% 67.21% +0.01%
==========================================
Files 563 569 +6
Lines 104254 104712 +458
==========================================
+ Hits 70059 70386 +327
- Misses 34195 34326 +131 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
mgeplf
reviewed
May 29, 2024
|
✔️ 51707da -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
1uc
reviewed
Jun 4, 2024
|
|
✔️ 58485cc -> Azure artifacts URL |
Collaborator
1uc
approved these changes
Jun 5, 2024
Member
|
I see some old suggestions but also see that PR was updated and approved afterward. So I will merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more details about how to use the TABLE statement and how it works.