Improve COMPARTMENT documentation.#2771
Merged
Merged
Conversation
fef8327 to
7b43755
Compare
Collaborator
Author
|
Locally a9cb398 renders as follows:
|
7b43755 to
a9cb398
Compare
|
Please retry analysis of this Pull-Request directly on SonarCloud |
|
✔️ a9cb398 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
|
✔️ a9cb398 -> Azure artifacts URL |
Collaborator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2771 +/- ##
==========================================
+ Coverage 66.91% 67.80% +0.88%
==========================================
Files 560 562 +2
Lines 104093 108370 +4277
==========================================
+ Hits 69659 73485 +3826
- Misses 34434 34885 +451 ☔ View full report in Codecov by Sentry. |
alkino
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for the non-indexed
COMPARTMENTis clear to me. For the indexed variant, it wasn't clear if the state variable should be an array variable, e.g.s, or an indexed array variable, i.e.s[i]. Similar in thevolumeexpression: are array variables automatically detected and the[i]is added automatically during codegen.This PR hopes to clarifies those two points.