Accessors for cache pointers.#2712
Merged
Merged
Conversation
In NMODL we have a struct:
struct ionic_Instance {
double* ena{};
double* ina{};
double* v_unused{};
double* g_unused{};
const double* const* ion_ina{};
double* const* ion_ena{};
ionic_Store* global{&ionic_global};
};
The pointers are views into contiguous arrays of doubles. While we
can the address for parameters like `ena`, we can't get the address
of "double pointer" variables, with the previous existing API.
pramodk
approved these changes
Feb 7, 2024
|
✔️ ea8b6fc -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2712 +/- ##
==========================================
- Coverage 66.14% 66.14% -0.01%
==========================================
Files 558 558
Lines 103641 103640 -1
==========================================
- Hits 68557 68551 -6
- Misses 35084 35089 +5 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
|
✔️ 32af72a -> Azure artifacts URL |
Collaborator
Collaborator
Author
|
@pramodk could we please merge this? We need it to be part of neuron-nightly which is used by NMODL CI. |
Member
|
@1uc : sorry, I missed the notification! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In NMODL we have a struct:
The pointers are views into contiguous arrays of doubles. While we can the address for parameters like
ena, we can't get the address of "double pointer" variables, with the previous existing API.