NEURON 9.0+ random API changes and Random123 documentation#2618
Merged
Conversation
|
✔️ d3600ee -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ d3600ee -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2618 +/- ##
==========================================
+ Coverage 66.18% 66.20% +0.01%
==========================================
Files 559 559
Lines 108956 108958 +2
==========================================
+ Hits 72112 72132 +20
+ Misses 36844 36826 -18 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
nrnhines
approved these changes
Nov 22, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
✔️ 8457458 -> Azure artifacts URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on some MOD files I came across I thought that it would be good to add some information regarding potential changes needed to MOD files that use legacy/old random API from NEURON.
Let me know if you think I should collaborate more on these changes, I should change any of the suggestions or give a better example for
Random123