Skip to content

Resolves restructuring caused by find_parent_seg#2593

Merged
ramcdougal merged 2 commits into
masterfrom
update_find_parent_seg
Oct 26, 2023
Merged

Resolves restructuring caused by find_parent_seg#2593
ramcdougal merged 2 commits into
masterfrom
update_find_parent_seg

Conversation

@rgourdine

Copy link
Copy Markdown
Collaborator

closes #1115

@rgourdine rgourdine requested a review from ramcdougal October 25, 2023 21:52
@rgourdine rgourdine self-assigned this Oct 25, 2023
@rgourdine rgourdine added the rxd reaction-diffusion label Oct 25, 2023
@azure-pipelines

Copy link
Copy Markdown

✔️ 0922679 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@ramcdougal ramcdougal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to remove the numpy dependency, but othertwise looks good.

@ramcdougal ramcdougal enabled auto-merge (squash) October 26, 2023 00:53
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@azure-pipelines

Copy link
Copy Markdown

✔️ 8e56a39 -> Azure artifacts URL

@ramcdougal ramcdougal merged commit a8a0060 into master Oct 26, 2023
@ramcdougal ramcdougal deleted the update_find_parent_seg branch October 26, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rxd reaction-diffusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

find_parent_seg uses h.distance(pt) not h.distance(pt1, pt2) possibly corrupting base point

3 participants