Skip to content

NVHPC: Fix issue with the addition of "-A" CXX flag for CMake < 3.19#2591

Merged
ohm314 merged 3 commits into
masterfrom
pramodk/nvhpc-build-fix
Nov 1, 2023
Merged

NVHPC: Fix issue with the addition of "-A" CXX flag for CMake < 3.19#2591
ohm314 merged 3 commits into
masterfrom
pramodk/nvhpc-build-fix

Conversation

@pramodk

@pramodk pramodk commented Oct 25, 2023

Copy link
Copy Markdown
Member

Fixes #2563

@pramodk
NVHPC: Fix issue with the addition of "-A" CXX flag for CMake < 3.19
e58a0c3 
- Import fix from CoreNEURON level to NEURON
- The issue also appears with compilation of flex generated
  lexer files, see #2563

Fixes #2563
@azure-pipelines

azure-pipelines Bot commented Oct 25, 2023

Copy link
Copy Markdown

✔️ e58a0c3 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines

azure-pipelines Bot commented Oct 27, 2023

Copy link
Copy Markdown

✔️ fb0de16 -> Azure artifacts URL

@codecov

codecov Bot commented Oct 27, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2591 (257fd12) into master (53264be) will increase coverage by 0.12%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2591      +/-   ##
==========================================
+ Coverage   66.07%   66.20%   +0.12%     
==========================================
  Files         559      559              
  Lines      108912   108910       -2     
==========================================
+ Hits        71962    72101     +139     
+ Misses      36950    36809     -141
Files Coverage Δ
src/ivoc/strfun.cpp 99.10% <100.00%> (+52.88%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

Sign in to view
ohm314
ohm314 approved these changes Nov 1, 2023
View reviewed changes

@ohm314 ohm314 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ohm314 ohm314 enabled auto-merge (squash) November 1, 2023 10:02
@sonarqubecloud

sonarqubecloud Bot commented Nov 1, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@azure-pipelines

azure-pipelines Bot commented Nov 1, 2023

Copy link
Copy Markdown

✔️ 257fd12 -> Azure artifacts URL

@ohm314 ohm314 merged commit 09a1db5 into master Nov 1, 2023
@ohm314 ohm314 deleted the pramodk/nvhpc-build-fix branch November 1, 2023 11:17
@bbpbuildbot

bbpbuildbot commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #166272 (:white_check_mark:) have been uploaded here!

Status and direct links:

@pramodk pramodk mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ohm314 ohm314 ohm314 approved these changes
@nrnhines nrnhines Awaiting requested review from nrnhines
@iomaganaris iomaganaris Awaiting requested review from iomaganaris

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue with GPU build using latest NVHPC compilers

3 participants

@pramodk @bbpbuildbot @ohm314