Skip to content

Resolve: NodeList.include_flux#2588

Merged
ramcdougal merged 13 commits into
masterfrom
node_flux
Oct 28, 2023
Merged

Resolve: NodeList.include_flux#2588
ramcdougal merged 13 commits into
masterfrom
node_flux

Conversation

@rgourdine

Copy link
Copy Markdown
Collaborator

closes #1644

@rgourdine rgourdine added the rxd reaction-diffusion label Oct 20, 2023
@rgourdine rgourdine requested a review from ramcdougal October 20, 2023 22:05
@rgourdine rgourdine self-assigned this Oct 20, 2023
@azure-pipelines

Copy link
Copy Markdown

✔️ e5b4d87 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@azure-pipelines

Copy link
Copy Markdown

✔️ 9f32be8 -> Azure artifacts URL

@codecov

codecov Bot commented Oct 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2588 (492a8a1) into master (3bbdd8d) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #2588      +/-   ##
==========================================
- Coverage   66.07%   66.07%   -0.01%     
==========================================
  Files         559      559              
  Lines      108910   108910              
==========================================
- Hits        71965    71962       -3     
- Misses      36945    36948       +3     
Files Coverage Δ
share/lib/python/neuron/rxd/nodelist.py 68.33% <100.00%> (+1.66%) ⬆️
share/lib/python/neuron/rxd/node.py 81.96% <80.00%> (+0.51%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

@azure-pipelines

Copy link
Copy Markdown

✔️ 07c32b6 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Comment thread test/rxd/test_nodelist_include_flux.py
@azure-pipelines

Copy link
Copy Markdown

✔️ a0b3d2b -> Azure artifacts URL

@azure-pipelines

Copy link
Copy Markdown

✔️ 096d139 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@azure-pipelines

Copy link
Copy Markdown

✔️ ecf70fc -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@azure-pipelines

Copy link
Copy Markdown

✔️ b2ebbb9 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@ramcdougal ramcdougal enabled auto-merge (squash) October 27, 2023 01:48
@azure-pipelines

Copy link
Copy Markdown

✔️ 585676d -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@azure-pipelines

Copy link
Copy Markdown

✔️ 492a8a1 -> Azure artifacts URL

@ramcdougal ramcdougal merged commit ca5730e into master Oct 28, 2023
@ramcdougal ramcdougal deleted the node_flux branch October 28, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rxd reaction-diffusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NodeList.include_flux doesn't work with constant fluxes

4 participants