Skip to content

Fixed mod file array variable assignment (seg.mech.array[i] = x)#2504

Merged
pramodk merged 1 commit into
masterfrom
hines/fix-modarray-assign
Sep 18, 2023
Merged

Fixed mod file array variable assignment (seg.mech.array[i] = x)#2504
pramodk merged 1 commit into
masterfrom
hines/fix-modarray-assign

Conversation

@nrnhines

@nrnhines nrnhines commented Sep 14, 2023

Copy link
Copy Markdown
Member

seg.mech.array[i] = x would assert if i > 0

Trivial fix for a bug that was mentioned in a companion comment, along with test of functionality.

@azure-pipelines

Copy link
Copy Markdown

✔️ 9fc95a9 -> Azure artifacts URL

@codecov

codecov Bot commented Sep 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2504 (9fc95a9) into master (e742cdf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2504   +/-   ##
=======================================
  Coverage   61.49%   61.49%           
=======================================
  Files         624      624           
  Lines      119190   119189    -1     
=======================================
+ Hits        73295    73297    +2     
+ Misses      45895    45892    -3     
Files Changed Coverage Δ
src/nrnpython/nrnpy_nrn.cpp 72.80% <100.00%> (+0.24%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nrnhines nrnhines changed the title Fixed mnod file array variable assignment (seg.mech.array[i] = x) Fixed mod file array variable assignment (seg.mech.array[i] = x) Sep 15, 2023
@nrnhines nrnhines mentioned this pull request Sep 16, 2023
5 tasks
@pramodk pramodk merged commit adec045 into master Sep 18, 2023
@pramodk pramodk deleted the hines/fix-modarray-assign branch September 18, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants