Skip to content

Add unit tests for OcFullMatrix#2474

Merged
pramodk merged 20 commits into
masterfrom
cornu/add_test_matrix
Aug 29, 2023
Merged

Add unit tests for OcFullMatrix#2474
pramodk merged 20 commits into
masterfrom
cornu/add_test_matrix

Conversation

@alkino

@alkino alkino commented Aug 24, 2023

Copy link
Copy Markdown
Member

No description provided.

@alkino

alkino commented Aug 24, 2023

Copy link
Copy Markdown
Member Author

Fix a bug in the same time in getdiag() and setdiag()

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines

azure-pipelines Bot commented Aug 24, 2023

Copy link
Copy Markdown

✔️ 1e2b194 -> Azure artifacts URL

@alkino alkino force-pushed the cornu/add_test_matrix branch from 1e2b194 to a70d1b4 Compare August 24, 2023 13:02
@codecov

codecov Bot commented Aug 24, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2474 (58539ec) into master (c3f5089) will increase coverage by 0.66%.
The diff coverage is 96.76%.

@@            Coverage Diff             @@
##           master    #2474      +/-   ##
==========================================
+ Coverage   60.42%   61.09%   +0.66%     
==========================================
  Files         627      628       +1     
  Lines      120823   121089     +266     
==========================================
+ Hits        73013    73976     +963     
+ Misses      47810    47113     -697
Files Changed Coverage Δ
src/ivoc/ocmatrix.h 4.95% <0.00%> (+1.98%) ⬆️
test/unit_tests/matrix.cpp 96.99% <96.99%> (ø)
src/ivoc/ocmatrix.cpp 88.44% <100.00%> (+48.63%) ⬆️

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino force-pushed the cornu/add_test_matrix branch from 783c3e8 to 98ee4aa Compare August 24, 2023 15:40
@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino added the nrn-modeldb-ci-nightly Launch external ModelDB CI label Aug 25, 2023
@github-actions github-actions Bot removed the nrn-modeldb-ci-nightly Launch external ModelDB CI label Aug 25, 2023
@github-actions

github-actions Bot commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

NEURON ModelDB CI: launching for 5e1562e via its drop url

alexsavulescu
alexsavulescu previously approved these changes Aug 25, 2023
View reviewed changes

@alexsavulescu alexsavulescu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@alexsavulescu alexsavulescu dismissed their stale review August 25, 2023 11:44

some tests are failing

@github-actions

github-actions Bot commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

NEURON ModelDB CI: 5e1562e -> download reports from here

@neuronsimulator neuronsimulator deleted a comment from azure-pipelines Bot Aug 28, 2023
@azure-pipelines

azure-pipelines Bot commented Aug 28, 2023

Copy link
Copy Markdown

✔️ 36a534f -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino force-pushed the cornu/add_test_matrix branch from 1aeb2ab to d6e6dde Compare August 28, 2023 20:14
@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines

azure-pipelines Bot commented Aug 28, 2023

Copy link
Copy Markdown

✔️ d6e6dde -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented Aug 28, 2023

Copy link
Copy Markdown

✔️ 45109a3 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino added the nrn-modeldb-ci-nightly Launch external ModelDB CI label Aug 29, 2023
@github-actions github-actions Bot removed the nrn-modeldb-ci-nightly Launch external ModelDB CI label Aug 29, 2023
@github-actions

github-actions Bot commented Aug 29, 2023

Copy link
Copy Markdown
Contributor

NEURON ModelDB CI: launching for 45109a3 via its drop url

1uc
1uc reviewed Aug 29, 2023
View reviewed changes
Comment thread src/ivoc/ocmatrix.cpp Outdated
1uc
1uc reviewed Aug 29, 2023
View reviewed changes
Comment thread src/ivoc/ocmatrix.cpp Outdated
1uc
1uc reviewed Aug 29, 2023
View reviewed changes
Comment thread src/ivoc/ocmatrix.cpp Outdated
alkino and others added 2 commits August 29, 2023 09:54
@alkino @1uc
Update src/ivoc/ocmatrix.cpp
f46427b 
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
@alkino @1uc
Update src/ivoc/ocmatrix.cpp
58539ec 
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
@azure-pipelines

azure-pipelines Bot commented Aug 29, 2023

Copy link
Copy Markdown

✔️ 58539ec -> Azure artifacts URL

@github-actions

github-actions Bot commented Aug 29, 2023

Copy link
Copy Markdown
Contributor

NEURON ModelDB CI: 45109a3 -> download reports from here

@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino closed this Aug 29, 2023
@alkino alkino reopened this Aug 29, 2023
@azure-pipelines

azure-pipelines Bot commented Aug 29, 2023

Copy link
Copy Markdown

✔️ 58539ec -> Azure artifacts URL

@bbpbuildbot

bbpbuildbot commented Aug 29, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #147317 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino

alkino commented Aug 29, 2023

Copy link
Copy Markdown
Member Author

@pramodk merge this?

pramodk
pramodk approved these changes Aug 29, 2023
View reviewed changes

@pramodk pramodk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I didn't check the test carefully but I see that Luc has reviewed it)

@pramodk pramodk merged commit 2fc6140 into master Aug 29, 2023
@pramodk pramodk deleted the cornu/add_test_matrix branch August 29, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1uc 1uc 1uc left review comments
@pramodk pramodk pramodk approved these changes
@alexsavulescu alexsavulescu alexsavulescu left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alkino @bbpbuildbot @pramodk @1uc @alexsavulescu