Use modern SoA helpers for fast_imem data.#2381
Merged
Merged
Conversation
olupton
commented
Jun 12, 2023
Contributor
|
Unable to retrieve AZURE drop url from comments! |
|
✔️ 1d295c3 -> Azure artifacts URL |
Contributor
Codecov Report
@@ Coverage Diff @@
## master #2381 +/- ##
==========================================
+ Coverage 60.16% 60.18% +0.01%
==========================================
Files 642 641 -1
Lines 121137 121169 +32
==========================================
+ Hits 72877 72920 +43
+ Misses 48260 48249 -11
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
Contributor
Also: * Drop set_area and set_v for uniformity. * Drop pointer-updating logic.
1d295c3 to
88a4ceb
Compare
|
✔️ 88a4ceb -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
Expand tests for optional fields in soa<...> containers, in particular using fast_imem fields in the Node data container. Because these can be toggled on and off, there are additional states that can be attained. As part of this, change the pretty-printing code to use the "T**" pointers to where the "T*" pointers are stored, instead of the "T*" values (== vec.data()), when searching for information about the container a data handle points into. This means that data handles to disabled columns can pretty-print as such, instead of having to pretty-print as being handles to unknown containers.
olupton
commented
Jun 14, 2023
|
✔️ 948673c -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ 25c731d -> Azure artifacts URL |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These data were already in SoA format, but bringing them into the ecosystem introduced in #2027 removes the final usage of some old pointer-updating logic, which in any case required contortions in Python scripts to get things to work. This can be removed because the new
data_handle<T>component can now handle referring toi_membrane_values.To enable this, add support to
neuron::container::soa<...>for fields that can be toggled active/inactive at runtime, and add new tests covering this. Note that the possibility of doing:and ending up with an invalid "
h" is qualitatively new, as this PR introduces the possibility of handles (which are basically (row, column) coordinates) being invalidated by the column (i.e. the optional field) becoming invalid, while the row (i.e.foo) remains valid).Also drop set_area and set_v for uniformity.