Skip to content

Add SEClamp to LFP calculation#2360

Merged
pramodk merged 3 commits into
masterfrom
jblanco/lfp_seclamp
May 17, 2023
Merged

Add SEClamp to LFP calculation#2360
pramodk merged 3 commits into
masterfrom
jblanco/lfp_seclamp

Conversation

@jorblancoa

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented May 15, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2360 (251a4e3) into master (d8e07da) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2360      +/-   ##
==========================================
- Coverage   58.85%   58.85%   -0.01%     
==========================================
  Files         626      626              
  Lines      119979   119982       +3     
==========================================
- Hits        70611    70610       -1     
- Misses      49368    49372       +4     
Impacted Files Coverage Δ
src/coreneuron/io/reports/report_handler.cpp 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@azure-pipelines

Copy link
Copy Markdown

✔️ 8a879dc -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@jorblancoa jorblancoa requested a review from pramodk May 15, 2023 12:28

@pramodk pramodk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a minor suggestion, LGTM!

Comment thread src/coreneuron/io/reports/report_handler.cpp Outdated
@azure-pipelines

Copy link
Copy Markdown

✔️ 1c9aa35 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@jorblancoa jorblancoa force-pushed the jblanco/lfp_seclamp branch from 1c9aa35 to 3f51803 Compare May 17, 2023 09:39
@azure-pipelines

Copy link
Copy Markdown

✔️ 3f51803 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@jorblancoa jorblancoa force-pushed the jblanco/lfp_seclamp branch from 3f51803 to 251a4e3 Compare May 17, 2023 12:05
@azure-pipelines

Copy link
Copy Markdown

✔️ 251a4e3 -> Azure artifacts URL

@pramodk pramodk merged commit c685dfc into master May 17, 2023
@pramodk pramodk deleted the jblanco/lfp_seclamp branch May 17, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants