Skip to content

Migration c to cpp in sparse13#2305

Merged
alexsavulescu merged 4 commits into
masterfrom
weji/sparse
Mar 28, 2023
Merged

Migration c to cpp in sparse13#2305
alexsavulescu merged 4 commits into
masterfrom
weji/sparse

Conversation

@WeinaJi

@WeinaJi WeinaJi commented Mar 24, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Mar 24, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2305 (bcfb6d4) into master (2ea1c37) will decrease coverage by 0.04%.
The diff coverage is 19.67%.

@@            Coverage Diff             @@
##           master    #2305      +/-   ##
==========================================
- Coverage   58.91%   58.88%   -0.04%     
==========================================
  Files         619      619              
  Lines      121637   121681      +44     
==========================================
- Hits        71666    71647      -19     
- Misses      49971    50034      +63     
Impacted Files Coverage Δ
src/nrniv/matrixmap.cpp 86.53% <ø> (ø)
src/nrnoc/multicore.cpp 90.69% <ø> (ø)
src/sparse13/spfactor.cpp 84.93% <ø> (ø)
src/sparse13/spoutput.cpp 0.00% <0.00%> (ø)
src/sparse13/sputils.cpp 0.00% <0.00%> (ø)
src/sparse13/spbuild.cpp 56.30% <49.24%> (ø)
src/sparse13/spsolve.cpp 51.06% <49.42%> (ø)
src/sparse13/spalloc.cpp 75.21% <76.99%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@azure-pipelines

Copy link
Copy Markdown

✔️ c6e9d76 -> Azure artifacts URL

@WeinaJi WeinaJi marked this pull request as ready for review March 24, 2023 13:22
@alexsavulescu alexsavulescu added the nrn-modeldb-ci-nightly Launch external ModelDB CI label Mar 24, 2023
@github-actions github-actions Bot removed the nrn-modeldb-ci-nightly Launch external ModelDB CI label Mar 24, 2023
@github-actions

Copy link
Copy Markdown
Contributor

NEURON ModelDB CI: launching for c6e9d76 via its drop url

Comment thread src/sparse13/spsolve.cpp
@github-actions

Copy link
Copy Markdown
Contributor

NEURON ModelDB CI: c6e9d76 -> download reports from here

@alexsavulescu

Copy link
Copy Markdown
Member

The substance of the PR LGTM overall. @nrnhines, are you aware of any extra tests that we may want to run before merging this?

@azure-pipelines

Copy link
Copy Markdown

✔️ 0f7476b -> Azure artifacts URL

Comment thread src/sparse13/spfactor.cpp Outdated
Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
@alexsavulescu alexsavulescu requested a review from nrnhines March 27, 2023 08:25
@azure-pipelines

Copy link
Copy Markdown

✔️ b8be691 -> Azure artifacts URL

@azure-pipelines

Copy link
Copy Markdown

✔️ bcfb6d4 -> Azure artifacts URL

@alexsavulescu alexsavulescu merged commit 5135c70 into master Mar 28, 2023
@alexsavulescu alexsavulescu deleted the weji/sparse branch March 28, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants