multi gridding tests#2260
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2260 +/- ##
==========================================
+ Coverage 57.25% 58.89% +1.64%
==========================================
Files 619 619
Lines 121571 121607 +36
==========================================
+ Hits 69601 71620 +2019
+ Misses 51970 49987 -1983
... and 32 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I'm having some trouble convincing myself that the new tests are being run... @adamjhn do you see, e.g. |
|
adamjhn
left a comment
There was a problem hiding this comment.
The changes look good, I just have a few suggestions about the tests;
Looks like test_multi_gridding_1.py, test_multi_gridding_2.py and test_multi_gridding_mix.py are useful for debugging, but maybe not for CI?
Maybe reduce the size (larger dx or smaller L) and get rid of one or both of the test_multi_gridding_1.py or test_multi_gridding_2.py, (which are more a test of rxd.Rate for 3d models than multigridding).
No description provided.