Skip to content

Remove old tqueue implementations#2225

Merged
olupton merged 7 commits into
masterfrom
olupton/remove-old-tqueue-implementations
Feb 17, 2023
Merged

Remove old tqueue implementations#2225
olupton merged 7 commits into
masterfrom
olupton/remove-old-tqueue-implementations

Conversation

@olupton

@olupton olupton commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator

Drop two old queue implementations and some unused macros.

@olupton olupton requested a review from nrnhines February 14, 2023 07:47
@azure-pipelines

Copy link
Copy Markdown

✔️ 6e20fb6 -> Azure artifacts URL

@codecov

codecov Bot commented Feb 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2225 (80b3e1b) into master (3665824) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2225   +/-   ##
=======================================
  Coverage   56.14%   56.14%           
=======================================
  Files         620      620           
  Lines      124222   124222           
=======================================
  Hits        69749    69749           
  Misses      54473    54473           
Impacted Files Coverage Δ
src/nrncvode/cvodeobj.cpp 86.59% <ø> (ø)
src/nrncvode/netcvode.cpp 88.91% <ø> (ø)
src/nrncvode/netcvode.h 100.00% <ø> (ø)
src/nrncvode/sptbinq.cpp 84.87% <ø> (ø)
src/nrncvode/sptbinq.h 100.00% <ø> (ø)
src/nrncvode/tqueue.cpp 43.33% <ø> (ø)
src/nrncvode/tqueue.h 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@azure-pipelines

Copy link
Copy Markdown

✔️ 0b48529 -> Azure artifacts URL

@azure-pipelines

Copy link
Copy Markdown

✔️ 67d9f07 -> Azure artifacts URL

@olupton olupton marked this pull request as ready for review February 17, 2023 10:37
@azure-pipelines

Copy link
Copy Markdown

✔️ ca45a2d -> Azure artifacts URL

@azure-pipelines

Copy link
Copy Markdown

✔️ 80b3e1b -> Azure artifacts URL

@nrnhines nrnhines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remain: 0 balanced binary tree queue, 3 splay tree for everything queue, 4 splaytree with splay tree fifo in some cases, 5 default splay tree with bin queue for some cases

Gone: 1 red black tree queue, 3 splay tree with fifo in some cases

@olupton olupton merged commit a1a905a into master Feb 17, 2023
@olupton olupton deleted the olupton/remove-old-tqueue-implementations branch February 17, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants