Skip to content

DOCS: updated CONSTANT and LOCAL construct docs#2152

Merged
alexsavulescu merged 6 commits into
masterfrom
pramodk/nmodl-const-local
Jan 20, 2023
Merged

DOCS: updated CONSTANT and LOCAL construct docs#2152
alexsavulescu merged 6 commits into
masterfrom
pramodk/nmodl-const-local

Conversation

@pramodk

@pramodk pramodk commented Jan 16, 2023

Copy link
Copy Markdown
Member

No description provided.

@pramodk pramodk requested review from alkino and iomaganaris January 16, 2023 15:50
Comment thread docs/python/modelspec/programmatic/mechanisms/nmodl.rst
@codecov-commenter

codecov-commenter commented Jan 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2152 (29858b5) into master (70c62a4) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2152      +/-   ##
==========================================
- Coverage   55.72%   55.69%   -0.04%     
==========================================
  Files         615      615              
  Lines      123853   123853              
==========================================
- Hits        69021    68979      -42     
- Misses      54832    54874      +42     
Impacted Files Coverage Δ
src/nrnmpi/bbsmpipack.cpp 83.05% <0.00%> (-9.75%) ⬇️
src/parallel/bbsclimpi.cpp 52.22% <0.00%> (-8.34%) ⬇️
src/parallel/bbssrvmpi.cpp 45.26% <0.00%> (-5.27%) ⬇️
src/parallel/bbs.cpp 72.90% <0.00%> (-1.53%) ⬇️
src/nrniv/nrnpy.cpp 68.57% <0.00%> (+4.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@azure-pipelines

Copy link
Copy Markdown

✔️ 9c0611b -> Azure artifacts URL

@azure-pipelines

Copy link
Copy Markdown

✔️ c08eed2 -> Azure artifacts URL

@azure-pipelines

Copy link
Copy Markdown

✔️ c0d96be -> Azure artifacts URL

- venv is part of python3
- no need of --user inside virtual env
@azure-pipelines

Copy link
Copy Markdown

✔️ 6772aaa -> Azure artifacts URL

@iomaganaris iomaganaris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from this issue I came across locally it LGTM

@azure-pipelines

Copy link
Copy Markdown

✔️ 3f5f168 -> Azure artifacts URL

@azure-pipelines

Copy link
Copy Markdown

✔️ 29858b5 -> Azure artifacts URL

@alexsavulescu alexsavulescu merged commit 4a7fc07 into master Jan 20, 2023
@alexsavulescu alexsavulescu deleted the pramodk/nmodl-const-local branch January 20, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants