CNRN: Bug fix with the checkpointing of VecPlay instances#2148
Merged
Conversation
- In thalamus simulations with coreneuron (@BBP) we saw following errors with checkpoining: ``` io/nrn_checkpoint.cpp:515: void coreneuron::CheckPoints::write_phase2(coreneuron::NrnThread &) const: Assertion `mtype >= 0' failed. ``` - Looking into model loading and checkpointing code we see that due to padding of mechanism data, the VecPlay can have point to the memory address beyond `ml->data + size_of_mech_instance * num_mech_instance` i.e. new limits for mechanism data are `ml->data + size_of_mech_instance * num_mech_instance_with_padding` - Here we fix the checkpointing code with the above calculation
Codecov Report
@@ Coverage Diff @@
## master #2148 +/- ##
=======================================
Coverage 49.93% 49.93%
=======================================
Files 615 615
Lines 123873 123873
=======================================
Hits 61851 61851
Misses 62022 62022
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nrnhines
approved these changes
Jan 11, 2023
|
✔️ 1ff994b -> Azure artifacts URL |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.