Migrate c code to c++ in scopmath by WeinaJi · Pull Request #2083 · neuronsimulator/nrn

WeinaJi · 2022-11-11T17:04:52Z

Compile sources as C++ instead of C, retire K&R syntax so this works.
Remove C linkage where possible
Try and include headers consistently to enforce consistency between declarations/definitions.
Delete some unused methods.

bbpbuildbot · 2022-11-11T17:09:35Z

Logfiles from GitLab pipeline #84048 (:no_entry:) have been uploaded here!

Status and direct links:

⛔ cmake_build: [cmake, ON, OFF, OFF, address]

codecov-commenter · 2022-11-11T17:26:05Z

Codecov Report

Merging #2083 (cc17815) into master (744581d) will increase coverage by 0.25%.
The diff coverage is 50.35%.

@@            Coverage Diff             @@
##           master    #2083      +/-   ##
==========================================
+ Coverage   49.25%   49.50%   +0.25%     
==========================================
  Files         520      517       -3     
  Lines      115746   115110     -636     
==========================================
- Hits        57006    56988      -18     
+ Misses      58740    58122     -618

Impacted Files	Coverage Δ
src/nmodl/kinetic.cpp	`85.92% <ø> (ø)`
src/nrnoc/hocprax.cpp	`74.49% <0.00%> (ø)`
src/oc/hocdec.h	`100.00% <ø> (ø)`
src/oc/mcran4.cpp	`64.91% <ø> (-1.19%)`	⬇️
src/scopmath/abort.cpp	`0.00% <0.00%> (ø)`
src/scopmath/advance.cpp	`0.00% <0.00%> (ø)`
src/scopmath/boundary.cpp	`0.00% <0.00%> (ø)`
src/scopmath/crank.cpp	`0.00% <0.00%> (ø)`
src/scopmath/crout_thread.cpp	`81.81% <ø> (ø)`
src/scopmath/deflate.cpp	`0.00% <0.00%> (ø)`
... and 57 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

azure-pipelines · 2022-11-11T18:05:20Z

✔️ de0a6e51415450d795266d30220de0172bb4a6c2 -> Azure artifacts URL

bbpbuildbot · 2022-11-14T09:43:43Z

Logfiles from GitLab pipeline #84198 (:no_entry:) have been uploaded here!

Status and direct links:

⛔ cmake_build: [cmake, ON, OFF, OFF, address]

azure-pipelines · 2022-11-14T10:06:44Z

✔️ 03d1dfbd7047791c21312b6eba48b8cc8778f03d -> Azure artifacts URL

bbpbuildbot · 2022-11-14T10:31:46Z

Logfiles from GitLab pipeline #84223 (:no_entry:) have been uploaded here!

Status and direct links:

⛔ cmake_build: [cmake, ON, OFF, OFF, address]

bbpbuildbot · 2022-11-14T10:31:50Z

Logfiles from GitLab pipeline #84224 (:no_entry:) have been uploaded here!

Status and direct links:

⛔ cmake_build: [cmake, ON, OFF, OFF, address]

bbpbuildbot · 2022-11-14T10:51:42Z

Logfiles from GitLab pipeline #84231 (:white_check_mark:) have been uploaded here!

Status and direct links:

✅ cmake_build: [cmake, ON, OFF, OFF, address]

bbpbuildbot · 2022-11-14T10:52:09Z

Logfiles from GitLab pipeline #84230 (:white_check_mark:) have been uploaded here!

Status and direct links:

✅ cmake_build: [cmake, ON, OFF, OFF, address]

azure-pipelines · 2022-11-14T11:24:11Z

✔️ 47915e4ebefd823f92a799e0aef4e3bc9f7beafd -> Azure artifacts URL

olupton

Good to see this 🎉 I haven't reviewed everything; just flagging a few things I did see.

…nclusion style

bbpbuildbot · 2022-11-23T14:40:36Z

Logfiles from GitLab pipeline #86511 (:white_check_mark:) have been uploaded here!

Status and direct links:

✅ cmake_build: [cmake, ON, OFF, OFF, address]

azure-pipelines · 2022-11-23T15:43:00Z

✔️ 01d9e7e -> Azure artifacts URL

bbpbuildbot · 2022-11-23T17:41:46Z

Logfiles from GitLab pipeline #86534 (:white_check_mark:) have been uploaded here!

Status and direct links:

✅ cmake_build: [cmake, ON, OFF, OFF, address]

azure-pipelines · 2022-11-23T18:06:50Z

✔️ f2024a3 -> Azure artifacts URL

bbpbuildbot · 2022-11-23T19:26:41Z

Logfiles from GitLab pipeline #86549 (:white_check_mark:) have been uploaded here!

Status and direct links:

✅ cmake_build: [cmake, ON, OFF, OFF, address]

azure-pipelines · 2022-11-23T19:54:46Z

✔️ cc17815 -> Azure artifacts URL

olupton · 2022-11-23T20:13:42Z

✔️ cc17815 -> Azure artifacts URL

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/3535363781

bbpbuildbot · 2022-11-23T22:53:27Z

Logfiles from GitLab pipeline #86558 (:white_check_mark:) have been uploaded here!

Status and direct links:

✅ cmake_build: [cmake, ON, OFF, OFF, address]

bbpbuildbot · 2022-11-23T22:58:50Z

Logfiles from GitLab pipeline #86559 (:white_check_mark:) have been uploaded here!

Status and direct links:

✅ cmake_build: [cmake, ON, OFF, OFF, address]

azure-pipelines · 2022-11-23T23:23:19Z

✔️ e936d49 -> Azure artifacts URL

olupton · 2022-11-24T06:07:22Z

✔️ e936d49 -> Azure artifacts URL

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/3538150725

alexsavulescu force-pushed the weji/scopmath_cpp branch from de0a6e5 to 03d1dfb Compare November 14, 2022 09:25

olupton reviewed Nov 14, 2022

View reviewed changes

Comment thread src/oc/oc_ansi.h Outdated

Comment thread src/nrniv/cxprop.cpp Outdated

Comment thread src/oc/mcran4.cpp Outdated

Comment thread src/scopmath/force.cpp Outdated

Comment thread src/scopmath/force.cpp Outdated

pramodk requested a review from iomaganaris November 14, 2022 13:14

Weina Ji and others added 5 commits November 23, 2022 14:08

Revert c code to c++ in scopmath

cdf59cb

fix-ups wrt master recent changes

50c6523

ilf

104f3a4

review comments

726152a

another pass trying to always include headers and enforce a uniform i…

01d9e7e

…nclusion style

olupton force-pushed the weji/scopmath_cpp branch from 47915e4 to 01d9e7e Compare November 23, 2022 14:32

euler and runge fixups from modeldb

f2024a3

olupton added 2 commits November 23, 2022 18:46

drop some apparently-unused methods

b3d9595

drop vsparse.cpp

cc17815

alexsavulescu marked this pull request as ready for review November 23, 2022 18:28

alexsavulescu approved these changes Nov 23, 2022

View reviewed changes

olupton added 2 commits November 23, 2022 23:44

delete some more commented code

c2c0fe9

delete one more

e936d49

olupton approved these changes Nov 24, 2022

View reviewed changes

olupton merged commit ce1caab into master Nov 24, 2022

olupton deleted the weji/scopmath_cpp branch November 24, 2022 08:01

olupton mentioned this pull request Dec 21, 2022

scopmath: make solvers header-only and begin templating them #2131

Merged

olupton mentioned this pull request Feb 20, 2023

scopmath: do not assume indices are integers #2241

Merged

Uh oh!

Conversation

WeinaJi commented Nov 11, 2022 • edited by olupton Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bbpbuildbot commented Nov 11, 2022

Uh oh!

codecov-commenter commented Nov 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

azure-pipelines Bot commented Nov 11, 2022

Uh oh!

bbpbuildbot commented Nov 14, 2022

Uh oh!

azure-pipelines Bot commented Nov 14, 2022

Uh oh!

bbpbuildbot commented Nov 14, 2022

Uh oh!

bbpbuildbot commented Nov 14, 2022

Uh oh!

bbpbuildbot commented Nov 14, 2022

Uh oh!

bbpbuildbot commented Nov 14, 2022

Uh oh!

azure-pipelines Bot commented Nov 14, 2022

Uh oh!

olupton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bbpbuildbot commented Nov 23, 2022

Uh oh!

azure-pipelines Bot commented Nov 23, 2022

Uh oh!

bbpbuildbot commented Nov 23, 2022

Uh oh!

azure-pipelines Bot commented Nov 23, 2022

Uh oh!

bbpbuildbot commented Nov 23, 2022

Uh oh!

azure-pipelines Bot commented Nov 23, 2022

Uh oh!

olupton commented Nov 23, 2022

Uh oh!

bbpbuildbot commented Nov 23, 2022

Uh oh!

bbpbuildbot commented Nov 23, 2022

Uh oh!

azure-pipelines Bot commented Nov 23, 2022

Uh oh!

olupton commented Nov 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WeinaJi commented Nov 11, 2022 •

edited by olupton

Loading

codecov-commenter commented Nov 11, 2022 •

edited

Loading