Skip to content

Migrate c code to c++ in scopmath#2083

Merged
olupton merged 10 commits into
masterfrom
weji/scopmath_cpp
Nov 24, 2022
Merged

Migrate c code to c++ in scopmath#2083
olupton merged 10 commits into
masterfrom
weji/scopmath_cpp

Conversation

@WeinaJi

@WeinaJi WeinaJi commented Nov 11, 2022

Copy link
Copy Markdown
Collaborator
  • Compile sources as C++ instead of C, retire K&R syntax so this works.
  • Remove C linkage where possible
  • Try and include headers consistently to enforce consistency between declarations/definitions.
  • Delete some unused methods.

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #84048 (:no_entry:) have been uploaded here!

Status and direct links:

@codecov-commenter

codecov-commenter commented Nov 11, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2083 (cc17815) into master (744581d) will increase coverage by 0.25%.
The diff coverage is 50.35%.

@@            Coverage Diff             @@
##           master    #2083      +/-   ##
==========================================
+ Coverage   49.25%   49.50%   +0.25%     
==========================================
  Files         520      517       -3     
  Lines      115746   115110     -636     
==========================================
- Hits        57006    56988      -18     
+ Misses      58740    58122     -618     
Impacted Files Coverage Δ
src/nmodl/kinetic.cpp 85.92% <ø> (ø)
src/nrnoc/hocprax.cpp 74.49% <0.00%> (ø)
src/oc/hocdec.h 100.00% <ø> (ø)
src/oc/mcran4.cpp 64.91% <ø> (-1.19%) ⬇️
src/scopmath/abort.cpp 0.00% <0.00%> (ø)
src/scopmath/advance.cpp 0.00% <0.00%> (ø)
src/scopmath/boundary.cpp 0.00% <0.00%> (ø)
src/scopmath/crank.cpp 0.00% <0.00%> (ø)
src/scopmath/crout_thread.cpp 81.81% <ø> (ø)
src/scopmath/deflate.cpp 0.00% <0.00%> (ø)
... and 57 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@azure-pipelines

Copy link
Copy Markdown

✔️ de0a6e51415450d795266d30220de0172bb4a6c2 -> Azure artifacts URL

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #84198 (:no_entry:) have been uploaded here!

Status and direct links:

@azure-pipelines

Copy link
Copy Markdown

✔️ 03d1dfbd7047791c21312b6eba48b8cc8778f03d -> Azure artifacts URL

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #84223 (:no_entry:) have been uploaded here!

Status and direct links:

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #84224 (:no_entry:) have been uploaded here!

Status and direct links:

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #84231 (:white_check_mark:) have been uploaded here!

Status and direct links:

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #84230 (:white_check_mark:) have been uploaded here!

Status and direct links:

@azure-pipelines

Copy link
Copy Markdown

✔️ 47915e4ebefd823f92a799e0aef4e3bc9f7beafd -> Azure artifacts URL

@olupton olupton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see this 🎉 I haven't reviewed everything; just flagging a few things I did see.

Comment thread src/oc/oc_ansi.h Outdated
Comment thread src/nrniv/cxprop.cpp Outdated
Comment thread src/oc/mcran4.cpp Outdated
Comment thread src/scopmath/force.cpp Outdated
Comment thread src/scopmath/force.cpp Outdated
@pramodk pramodk requested a review from iomaganaris November 14, 2022 13:14
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #86511 (:white_check_mark:) have been uploaded here!

Status and direct links:

@azure-pipelines

Copy link
Copy Markdown

✔️ 01d9e7e -> Azure artifacts URL

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #86534 (:white_check_mark:) have been uploaded here!

Status and direct links:

@azure-pipelines

Copy link
Copy Markdown

✔️ f2024a3 -> Azure artifacts URL

@alexsavulescu alexsavulescu marked this pull request as ready for review November 23, 2022 18:28
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #86549 (:white_check_mark:) have been uploaded here!

Status and direct links:

@azure-pipelines

Copy link
Copy Markdown

✔️ cc17815 -> Azure artifacts URL

@olupton

olupton commented Nov 23, 2022

Copy link
Copy Markdown
Collaborator

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #86558 (:white_check_mark:) have been uploaded here!

Status and direct links:

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #86559 (:white_check_mark:) have been uploaded here!

Status and direct links:

@azure-pipelines

Copy link
Copy Markdown

✔️ e936d49 -> Azure artifacts URL

@olupton

olupton commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants