section connect obj.secarray[i](0), 1 is valid syntax#2066
Merged
Conversation
Collaborator
|
Thanks! Launched a pipeline to test our internal models (they passed, but the NEURON tests all failed because it was pre-5aa6942). And another one, which all passed. |
Collaborator
|
Logfiles from GitLab pipeline #82790 (:no_entry:) have been uploaded here! Status and direct links: |
Closed
Collaborator
|
Logfiles from GitLab pipeline #82791 (:no_entry:) have been uploaded here! Status and direct links: |
Collaborator
|
Logfiles from GitLab pipeline #82802 (:white_check_mark:) have been uploaded here! Status and direct links: |
|
✔️ 5aa6942 -> Azure artifacts URL |
olupton
approved these changes
Nov 4, 2022
Collaborator
|
Logfiles from GitLab pipeline #82823 (:white_check_mark:) have been uploaded here! Status and direct links: |
|
✔️ fdd71da -> Azure artifacts URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes error introduced by #2024
I am going to review all use of
hoc_arayptwith respect to whether it is possible for an array to be missing an ndim stack item and that not be an error.Anyway, please check to see if this fixes the issue seen with the old circuit.