Skip to content

Minor improvements from #2027#2051

Merged
olupton merged 4 commits into
masterfrom
olupton/bits-and-bobs
Nov 1, 2022
Merged

Minor improvements from #2027#2051
olupton merged 4 commits into
masterfrom
olupton/bits-and-bobs

Conversation

@olupton

@olupton olupton commented Nov 1, 2022

Copy link
Copy Markdown
Collaborator

Changes that could easily be extracted from #2027.

  • Tell clang-format how to interpret PyObject_HEAD
  • Drop isoc99.{h,cpp} and nrn_isdouble function
  • Update submodule to include Allow Custom build type iv#45 so one can build with -DCMAKE_BUILD_TYPE=Custom and -DNRN_ENABLE_INTERVIEWS=ON.
  • Add missing include in src/ivoc/ocnotify.h
  • Drop a lot of unused code in cxprop.cpp -- note that the 6th line of nrn_cache_prop_realloc was a return statement, and has been for some time.

Comment thread src/nrniv/cxprop.cpp
@azure-pipelines

Copy link
Copy Markdown

✔️ 735935d -> Azure artifacts URL

@olupton

olupton commented Nov 1, 2022

Copy link
Copy Markdown
Collaborator Author

@olupton olupton requested review from alkino and nrnhines November 1, 2022 15:31
@olupton

olupton commented Nov 1, 2022

Copy link
Copy Markdown
Collaborator Author

@olupton olupton marked this pull request as ready for review November 1, 2022 16:12
@olupton olupton merged commit 53f87a1 into master Nov 1, 2022
@olupton olupton deleted the olupton/bits-and-bobs branch November 1, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants