Assorted improvements from #1929#2015
Merged
Merged
Conversation
|
✔️ 27bf71d506569bbab5eb0800502cf09422e66516 -> Azure artifacts URL |
|
✔️ de5169c78b82802abfe043bd2d85986fd217d119 -> Azure artifacts URL |
Codecov Report
@@ Coverage Diff @@
## master #2015 +/- ##
==========================================
- Coverage 47.51% 47.51% -0.01%
==========================================
Files 528 528
Lines 118852 118802 -50
==========================================
- Hits 56468 56444 -24
+ Misses 62384 62358 -26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
✔️ 2cf08fea077eb7aa5336caa40f198da794cd8462 -> Azure artifacts URL |
2cf08fe to
b679f16
Compare
|
✔️ b679f16 -> Azure artifacts URL |
alexsavulescu
approved these changes
Oct 10, 2022
Member
Not inflicted by this PR. Related to #1663 |
pramodk
reviewed
Oct 10, 2022
pramodk
left a comment
Member
There was a problem hiding this comment.
a few minor questions for clarity otherwise looks good to me!
pramodk
approved these changes
Oct 10, 2022
|
✔️ 3f6b2c3 -> Azure artifacts URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various incidental improvements from #1929.
STETransitionet al. now use STL components#if 0block innrn_finitializefixes formatting theretable_check_no longer usesDatumPyHocObjectis consistently defined in only one placeexample_nmodltests are unpacked into different tests, Python versions are run (not just HOC)