Skip to content

Remove preprocessor variable live-debug-ci#2007

Merged
pramodk merged 12 commits into
masterfrom
cornu/remove_PPvar
Oct 6, 2022
Merged

Remove preprocessor variable live-debug-ci#2007
pramodk merged 12 commits into
masterfrom
cornu/remove_PPvar

Conversation

@alkino

@alkino alkino commented Oct 4, 2022

Copy link
Copy Markdown
Member

Because the value never change
NMODL = 1
VECTORIZE = 1
NOCMODL = 1
CVODE = 1
METHOD3 = 0

@pramodk

pramodk commented Oct 4, 2022

Copy link
Copy Markdown
Member

@nrnhines: as we started looking into legacy code & constructs, sometime it's hard / confusing to easily find which features or variables are relevant today. So we thought it would be best to delete the code parts that are not relevant today.

Do you think it's ok to remove the #else parts of the preprocessor directories mentioned above?

@codecov-commenter

codecov-commenter commented Oct 4, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.50%. Comparing base (0cdcc5c) to head (416069a).
⚠️ Report is 2875 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2007      +/-   ##
==========================================
- Coverage   47.51%   47.50%   -0.01%     
==========================================
  Files         527      527              
  Lines      118886   118877       -9     
==========================================
- Hits        56483    56473      -10     
- Misses      62403    62404       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alkino alkino force-pushed the cornu/remove_PPvar branch from 778e88f to 277dd01 Compare October 4, 2022 15:51
@azure-pipelines

Copy link
Copy Markdown

✔️ a9953cb -> Azure artifacts URL

@alkino alkino changed the title Remove preprocessor variable Remove preprocessor variable live-debug-ci Oct 5, 2022
@alkino alkino closed this Oct 5, 2022
@alkino alkino reopened this Oct 5, 2022
@nrnhines

nrnhines commented Oct 6, 2022

Copy link
Copy Markdown
Member

@nrnhines: as we started looking into legacy code & constructs, sometime it's hard / confusing to easily find which features or variables are relevant today. So we thought it would be best to delete the code parts that are not relevant today.

Do you think it's ok to remove the #else parts of the preprocessor directories mentioned above?

I have no objection to the removal.

@alkino alkino marked this pull request as ready for review October 6, 2022 09:20
@azure-pipelines

Copy link
Copy Markdown

✔️ 416069a -> Azure artifacts URL

Comment thread src/nmodl/modl.cpp
Comment thread src/nrncvode/occvode.cpp
Comment thread src/nrnoc/solve.cpp

@pramodk pramodk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodk pramodk merged commit 382266a into master Oct 6, 2022
@pramodk pramodk deleted the cornu/remove_PPvar branch October 6, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants