Skip to content

Remove PARTIAL / FIRST / LAST rules#2001

Merged
pramodk merged 1 commit into
masterfrom
remove_partial_first_last
Sep 29, 2022
Merged

Remove PARTIAL / FIRST / LAST rules#2001
pramodk merged 1 commit into
masterfrom
remove_partial_first_last

Conversation

@alkino

@alkino alkino commented Sep 29, 2022

Copy link
Copy Markdown
Member

See #1957

@alkino alkino force-pushed the remove_partial_first_last branch from 2feee9c to 34a8059 Compare September 29, 2022 08:48

@pramodk pramodk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alkino: I didn't grep myself for the usages and see if all related fragments are deleted but I am sure you have checked that.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #2001 (34a8059) into master (9c317e3) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2001      +/-   ##
==========================================
+ Coverage   46.54%   46.59%   +0.05%     
==========================================
  Files         526      525       -1     
  Lines      118997   118869     -128     
==========================================
  Hits        55387    55387              
+ Misses      63610    63482     -128     
Impacted Files Coverage Δ
src/modlunit/init.cpp 100.00% <ø> (ø)
src/nmodl/init.cpp 100.00% <ø> (ø)
src/nmodl/solve.cpp 67.54% <ø> (+2.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@azure-pipelines

Copy link
Copy Markdown

✔️ 34a8059 -> Azure artifacts URL

@pramodk pramodk merged commit 06615ec into master Sep 29, 2022
@pramodk pramodk deleted the remove_partial_first_last branch September 29, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants