Skip to content

Remove PUTQ / GETQ#1956

Merged
alexsavulescu merged 2 commits into
masterfrom
remove_getq_putq
Sep 9, 2022
Merged

Remove PUTQ / GETQ#1956
alexsavulescu merged 2 commits into
masterfrom
remove_getq_putq

Conversation

@alkino

@alkino alkino commented Aug 18, 2022

Copy link
Copy Markdown
Member

Those feature seems to be outdated and unused today.

Let's try to remove it.

Waiting for @nrnhines review (is it really useless?)

@azure-pipelines

Copy link
Copy Markdown

✔️ bb68a06 -> Azure artifacts URL

@pramodk pramodk requested a review from nrnhines September 6, 2022 16:52
@alkino alkino marked this pull request as ready for review September 9, 2022 07:29
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1956 (7a266d6) into master (32c055e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1956   +/-   ##
=======================================
  Coverage   46.49%   46.50%           
=======================================
  Files         526      526           
  Lines      119274   119258   -16     
=======================================
  Hits        55459    55459           
+ Misses      63815    63799   -16     
Impacted Files Coverage Δ
src/modlunit/init.cpp 100.00% <ø> (ø)
src/nmodl/init.cpp 100.00% <ø> (ø)
src/nmodl/parsact.cpp 73.52% <ø> (+1.82%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@azure-pipelines

Copy link
Copy Markdown

✔️ 7a266d6 -> Azure artifacts URL

@alexsavulescu alexsavulescu merged commit 8e9317a into master Sep 9, 2022
@alexsavulescu alexsavulescu deleted the remove_getq_putq branch September 9, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants