Consistent use of NrnThread, better declarations.#1609
Merged
Conversation
alkino
approved these changes
Jan 31, 2022
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
==========================================
- Coverage 45.18% 45.14% -0.04%
==========================================
Files 551 551
Lines 111191 111190 -1
==========================================
- Hits 50242 50198 -44
- Misses 60949 60992 +43
Continue to review full report at Codecov.
|
nrnhines
approved these changes
Jan 31, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another precursor to #1597 -- we still generate C code for mechanisms, but it is closer to being valid C++.
Changes in this PR:
src/nrnoc/nrnnoiv.cpp, which does not seem to be used or referenced anywhere.NrnThread, instead of using_NrnThreadin some places. Drop#define NrnThread _NrnThreadmagic._NrnThreadtriggers undefined behaviour.nocmodlgenerates function declarations, add the full prototype instead of using C-style declarations that do not specify the number of types of parameters. (double _hoc_%s,static void _ba%d)(Point_process* _pnt, double* _args, double _lflag),double _watch%d_cond(Point_process* _pnt))_nrn_thread_getelm,check_table_thread_,bbcore_write_t)matherr1by correcting its return type._XOPEN_SOURCEbefore defining it.