Add channel-benchmark to CTest suite.#1439
Merged
Merged
Conversation
8967f9a to
b6ef6dc
Compare
Collaborator
Author
|
The CI of BlueBrain/CoreNeuron#640 included this PR and BlueBrain/spack#1303. Everything passed. You can see the channel benchmark tests in, for example, https://gist.githubusercontent.com/bbpbuildbot/ab8124dd7330b10694fad0e41aa474f8/raw/8c102258299d4f79492ffdbe0fb538ec4c4a920d/test-neuron-nmodl-gpu.txt |
pramodk
reviewed
Sep 21, 2021
fffdb53 to
54344f7
Compare
54344f7 to
c9a78d7
Compare
pramodk
reviewed
Oct 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #1439 +/- ##
==========================================
+ Coverage 40.68% 40.75% +0.07%
==========================================
Files 548 548
Lines 106459 106459
==========================================
+ Hits 43308 43392 +84
+ Misses 63151 63067 -84
Continue to review full report at Codecov.
|
alexsavulescu
left a comment
Member
There was a problem hiding this comment.
Apart from Pramod's comments, LGTM
🚀
Test Hippocampus and SSCx separately. For each one, compare NEURON with CoreNEURON executing on (whatever is enabled of) CPU and GPU in both direct transfer mode and file transfer mode.
c9a78d7 to
f8724fe
Compare
alexsavulescu
approved these changes
Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new option,
NRN_ENABLE_TESTS_BBP, which steers whether or not tests that require BBP authentication to clone are included in the CTest suite.Test Hippocampus and SSCx separately. For each one, compare NEURON with CoreNEURON executing on (whatever is enabled of) CPU and GPU in both direct transfer mode and file transfer mode.
Possible TODO: add a way of passing an alternative commit of the external repository via the CMake command line. That could be used in the CI pipeline of the external repository itself.
cc: @iomaganaris @pramodk