Skip to content

ENH add kernel method parameter on posterior predictions#345

Merged
PSSF23 merged 11 commits intomainfrom
honestpruneoblique
Feb 19, 2025
Merged

ENH add kernel method parameter on posterior predictions#345
PSSF23 merged 11 commits intomainfrom
honestpruneoblique

Conversation

@YuxinB
Copy link
Copy Markdown
Member

@YuxinB YuxinB commented Feb 7, 2025

(just outpit the leaves value)

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Copy link
Copy Markdown
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuxinB As Adam suggested before, can you add a hyperparameter to turn this function on/off? The kernel method should be the default, but I believe we still need to preserve the standard averaging method.

@YuxinB
Copy link
Copy Markdown
Member Author

YuxinB commented Feb 11, 2025

https://github.com/neurodata/treeple/commits/main/ can some one help me check commits here

@YuxinB
Copy link
Copy Markdown
Member Author

YuxinB commented Feb 11, 2025

kay, will change later this week!

Copy link
Copy Markdown
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuxinB You can ignore the check errors for the sklearn fork. But can you fix the style and lint errors? Thanks! After that I'll merge the changes.

Copy link
Copy Markdown
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuxinB On second thought, we should not merge the changes until the parameter is implemented. We need to also make sure the forest level predict_proba outputs correctly when testing on an held-out set.

@YuxinB
Copy link
Copy Markdown
Member Author

YuxinB commented Feb 17, 2025

okay, I will implement the parameter by the end of this week.

Copy link
Copy Markdown
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify all the default values to what we agreed on.

@PSSF23 PSSF23 changed the title modify probability prediction to kernel version ENH add kernel method parameter on posterior predictions Feb 19, 2025
Copy link
Copy Markdown
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to facilitate productivity.

@PSSF23 PSSF23 merged commit 0f04561 into main Feb 19, 2025
20 of 31 checks passed
@PSSF23 PSSF23 deleted the honestpruneoblique branch February 19, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants