Skip to content

[TEST] Updated unit-test with HonestForestClassifier#118

Closed
adam2392 wants to merge 7 commits intotemp2from
update_test
Closed

[TEST] Updated unit-test with HonestForestClassifier#118
adam2392 wants to merge 7 commits intotemp2from
update_test

Conversation

@adam2392
Copy link
Copy Markdown
Collaborator

Fixes #

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Copy link
Copy Markdown
Collaborator Author

FYI @PSSF23 I have updated the PR here to reflect the latest changes in scikit-learn fork. However, as you can see the partial_fit triggers a seg fault on HonestForestClassifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant