Skip to content

Segmentation faults during partial_fit for check_fit_score_takes_y unit-test in scikit-learn #57

@adam2392

Description

@adam2392

Describe the bug

During the unit-test of RandomForestClassifier and ExtraTreesClassifier, it seems that there is some segmentation fault arising from partial_fit tree builder build function.

I suspect, this has something to do with either:

i) pickling and then accessing something that isn't restored properly
ii) accessing memory that isn't allocated

It would be great if it could be reproduced, but I fail to do so locally. This suggests to me it could be an edge case, but then that's even more important to fix.

Steps/Code to Reproduce

TBD.

Expected Results

There should be no segmentation fault.

Actual Results

.....................................................Fatal Python error: Segmentation fault

Thread 0x00007000107d4000 (most recent call first):
  File "/usr/local/miniconda/envs/testvenv/lib/python3.11/threading.py", line 320 in wait
  File "/usr/local/miniconda/envs/testvenv/lib/python3.11/site-packages/joblib/externals/loky/backend/queues.py", line 113 in _feed
  File "/usr/local/miniconda/envs/testvenv/lib/python3.11/threading.py", line 975 in run
  File "/usr/local/miniconda/envs/testvenv/lib/python3.11/threading.py", line 1038 in _bootstrap_inner
  File "/usr/local/miniconda/envs/testvenv/lib/python3.11/threading.py", line 995 in _bootstrap

Thread 0x000070000f7d1000 (most recent call first):
  File "/usr/local/miniconda/envs/testvenv/lib/python3.11/selectors.py", line 415 in select
  File "/usr/local/miniconda/envs/testvenv/lib/python3.11/multiprocessing/connection.py", line 930 in wait
  File "/usr/local/miniconda/envs/testvenv/lib/python3.11/site-packages/joblib/externals/loky/process_executor.py", line 611 in wait_result_broken_or_wakeup
  File "/usr/local/miniconda/envs/testvenv/lib/python3.11/site-packages/joblib/externals/loky/process_executor.py", line 557 in run
  File "/usr/local/miniconda/envs/testvenv/lib/python3.11/threading.py", line 1038 in _bootstrap_inner
  File "/usr/local/miniconda/envs/testvenv/lib/python3.11/threading.py", line 995 in _bootstrap

Versions

sklearn submodulev3 branch

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions