This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Merged
Conversation
this is for compatibility with the maximum currently allowed version of `starlette`. `anyio` just pushed a 4.0.0 that is incompatible with earlier versions of `starlette`. Note that this is now fixed in later versions (`deepsparse` has not yet tested against newer versions of `fastapi` and `starlette`). See: Kludex/starlette#1936 from internal bug report: ``` Our Deepsparse GHA is failing with starlette error: AttributeError: module 'anyio' has no attribute 'start_blocking_portal' ```
mgoin
approved these changes
Aug 31, 2023
Member
mgoin
left a comment
There was a problem hiding this comment.
Looks good from GHA testing for that error. There are still other asserts for another issue
Contributor
Author
|
GHA failure looks unrelated and on the sparsezoo side - pushing this patch |
Contributor
Author
|
Confirmed with @tdg5 the issue may be due to an internal migration. Issue is now tracked internally with fix underway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is for compatibility with the maximum currently allowed version of
starlette.anyiojust pushed a 4.0.0 that is incompatible with earlier versions ofstarlette.Note that this is now fixed in later versions (
deepsparsehas not yet tested against newer versions offastapiandstarlette). See: Kludex/starlette#1936from internal bug report: