[Bugfix] Fix incorrect single-token saves in v1 (#653)#13
Merged
vMaroon merged 1 commit intoneuralmagic:devfrom May 16, 2025
Merged
[Bugfix] Fix incorrect single-token saves in v1 (#653)#13vMaroon merged 1 commit intoneuralmagic:devfrom
vMaroon merged 1 commit intoneuralmagic:devfrom
Conversation
vllm v1: Fix saves chunk boundary This commit fixes the chunk boundary for saves in the vllm v1 adatper. Before this fix, it was possible that a single token writes were not skipped. Signed-off-by: Or Ozeri <oro@il.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vllm v1: Fix saves chunk boundary
This commit fixes the chunk boundary for saves in the vllm v1 adatper. Before this fix, it was possible that a single token writes were not skipped.