Skip to content

Testing improvement in generators/line.py#6204

Closed
Mjh9122 wants to merge 6 commits intonetworkx:mainfrom
Mjh9122:line.py-test
Closed

Testing improvement in generators/line.py#6204
Mjh9122 wants to merge 6 commits intonetworkx:mainfrom
Mjh9122:line.py-test

Conversation

@Mjh9122
Copy link
Copy Markdown
Contributor

@Mjh9122 Mjh9122 commented Nov 10, 2022

No description provided.

Copy link
Copy Markdown
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert all of the deleted newlines in networkx/generators/line.py? Not sure what happened there but we definitely don't want to get rid of those.

Copy link
Copy Markdown
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the newlines are gone but there are extra whitespaces at the start of the lines. If possible, it'd be better to revert the commit where the newlines were added instead of manually adding them back to avoid other formatting issues like this.

Also check out the developer guide, particularly the section on setting up a development environment and running e.g. black, which should prevent issues like this.

@Mjh9122 Mjh9122 closed this Nov 14, 2022
@Mjh9122 Mjh9122 deleted the line.py-test branch February 27, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants