Testing improvement in generators/line.py#6204
Closed
Mjh9122 wants to merge 6 commits intonetworkx:mainfrom
Closed
Testing improvement in generators/line.py#6204Mjh9122 wants to merge 6 commits intonetworkx:mainfrom
Mjh9122 wants to merge 6 commits intonetworkx:mainfrom
Conversation
rossbar
reviewed
Nov 11, 2022
Contributor
rossbar
left a comment
There was a problem hiding this comment.
Can you revert all of the deleted newlines in networkx/generators/line.py? Not sure what happened there but we definitely don't want to get rid of those.
rossbar
reviewed
Nov 11, 2022
Contributor
rossbar
left a comment
There was a problem hiding this comment.
Now the newlines are gone but there are extra whitespaces at the start of the lines. If possible, it'd be better to revert the commit where the newlines were added instead of manually adding them back to avoid other formatting issues like this.
Also check out the developer guide, particularly the section on setting up a development environment and running e.g. black, which should prevent issues like this.
# Conflicts: # networkx/generators/line.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.