Adds modularity measure for communities.#1729
Merged
hagberg merged 2 commits intonetworkx:masterfrom Jan 15, 2017
Merged
Conversation
This was referenced Aug 10, 2015
Member
|
Need to fix conflicts and coordinate with #1733 |
| from .community_utils import is_partition | ||
|
|
||
|
|
||
| def modularity(G, communities, weight='weight'): |
Member
There was a problem hiding this comment.
Won't we have a name conflict/confusion here with modularity used as both the function and module name?
Contributor
Author
There was a problem hiding this comment.
Do you mean for references in the documentation? In general having a module-level attribute with the same name as a module is fine: datetime.datetime for example.
Member
There was a problem hiding this comment.
Of course you can. But bad stuff is more likely to happen #2087 and another recent case I can't remember right now.
Member
There was a problem hiding this comment.
A possible solution might be to add modularity to quality.py instead of adding a new module modularity.py.
Member
|
Needs merge conflict update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is from pull request #764. I made PEP8 and style fixes.