Skip to content

Work247-ecomode_addon #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jimklimov merged 2 commits into from
Nov 17, 2024
Merged

Work247-ecomode_addon #2680

jimklimov merged 2 commits into from
Nov 17, 2024

Conversation

@masterwishx
Copy link
Contributor

@masterwishx masterwishx commented Nov 15, 2024 •
edited
Loading

As add-on for #2637 ECO/Bypass for Eaton Models
we can leave as is now only check range by r/w values or set also check range for eco/bypass by commands .

Also we can add ESS Mode staff (check range and set ups status) like in ECO mode
if it needed .

But only Eaton Models like 93PM G2 and 9395P use ESS , not sure if they use NUT :)

@masterwishx
add check range for eco/bypass commands
66947d8 
Signed-off-by: DaRK AnGeL <28630321+masterwishx@users.noreply.github.com>
@AppVeyorBot
Copy link

AppVeyorBot commented Nov 15, 2024

❌ Build nut 2.8.2.2360-master failed (commit 3a5095f420 by @masterwishx)

@masterwishx
fix commands func
6373635 
Signed-off-by: DaRK AnGeL <28630321+masterwishx@users.noreply.github.com>
@AppVeyorBot
Copy link

AppVeyorBot commented Nov 15, 2024

✅ Build nut 2.8.2.2361-master completed (commit 30ea845336 by @masterwishx)

@masterwishx
Copy link
Contributor Author

masterwishx commented Nov 16, 2024

We can also make automatic ECO steps...
@jimklimov please confirm if we need all this

@jimklimov jimklimov merged commit b624145 into networkupstools:master Nov 17, 2024
@jimklimov
Copy link
Member

jimklimov commented Nov 17, 2024

Looks good, and I think more details is better too.

CCing @arnaudquette-eaton also.

@jimklimov jimklimov added enhancement Eaton USB ECO/ESS/HE/ABM modes Non-trivial power supply management modes (ECO, ESS, HE, ABM etc.) labels Nov 17, 2024
@jimklimov jimklimov added this to the 2.8.3 milestone Nov 17, 2024
@jimklimov
Copy link
Member

jimklimov commented Nov 17, 2024

NOTE FIR SEKF: check that subdriver version is bumped since last release, but suffices once across several recent PRs.

@masterwishx
Copy link
Contributor Author

masterwishx commented Nov 17, 2024

Looks good, and I think more details is better too.

CCing @arnaudquette-eaton also.

What details you mean?
In new pr we can:

  1. You think we can add ESS stuff also, hovewere
    Only enterprise upses have it?

  2. We can add also post limits not passed in debug when check range eco/bypass func.

  3. We can add also maybe auto function for ECO that insert to bypass and then to eco.
    Instead user manually make thouse steps.

Also for now can't leave eco mode by commands but maybe Becouse my ussue with timeout, not shure...

@masterwishx
Copy link
Contributor Author

masterwishx commented Nov 17, 2024

NOTE FIR SEKF: check that subdriver version is bumped since last release, but suffices once across several recent PRs.

It was bumped in eco pr

@masterwishx masterwishx deleted the work2471-eco_addon branch November 17, 2024 20:53
@masterwishx masterwishx mentioned this pull request Nov 18, 2024
Merged
This was referenced Nov 26, 2024
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Eaton ECO/ESS/HE/ABM modes Non-trivial power supply management modes (ECO, ESS, HE, ABM etc.) enhancement USB

Projects

None yet

Milestone

2.8.3

Development

Successfully merging this pull request may close these issues.

3 participants

@masterwishx @AppVeyorBot @jimklimov