-
-
Notifications
You must be signed in to change notification settings - Fork 413
Driver reload - basic support
#1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…artab_t->reloadable field [networkupstools#1903]
…testinfo_reloadable() a public API in case drivers would need to know [networkupstools#1903]
…f the driver must be restarted to apply a value change [networkupstools#1903]
…fore- or back-ground)
…odified settings during reload [networkupstools#1903]
…eport if nut_debug_level_args overrides smaller/unset nut_debug_level_upsconf
…K_GETTIME and HAVE_CLOCK_MONOTONIC [networkupstools#1903]
…ype=notify-reload and enable it for nut-driver@.service if applicable [networkupstools#1903]
…stemd Type=notify for good measure [networkupstools#1903, networkupstools#1590]
… to send SIGHUP to a driver [networkupstools#1903]
…k to raw vars for older tools
… if changed configs that can not be applied on the fly [networkupstools#1903]
…tive and refactor as handle_reload_flag() [networkupstools#1903]
…iled to connect() to a driver pipe [networkupstools#1908]
… STATEPATH from file [networkupstools#1908]
This was referenced Apr 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
NUT protocols
nut-driver-enumerator (NDE)
nut-driver-enumerator (NDE) automates service management integration for NUT driver instances etc.
service/daemon start/stop
General subject for starting and stopping NUT daemons (drivers, server, monitor); also BG/FG/Debug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1903 by adding on-the-fly reloading config concept to NUT drivers (e.g. to change
debug_minsettings) via SIGHUP, and enhances #1590 by adding systemdType=notify-reloadsupport (introduced there just recently, in 2023 - systemd/systemd#25916).Also addresses a few other issues:
Closes: #1907
Closes: #1908
Note that in practical setups with systemd
nut-driver-enumerator.service/.path, it may detect change ofups.confand cause restart of the driver instead of reload. This would be tackled later. As currently presented, the feature is of practical use for developers (running drivers from a build workspace), and on systems managing the driver population without NDE.CC/FYI : @clepple @aquette @bigon @svarshavchik