Introduce forceHttps flag in JsonSchemaFactory.Builder#400
Merged
stevehu merged 2 commits intonetworknt:masterfrom Apr 15, 2021
PicnicSupermarket:hsener/gh-314
Merged
Introduce forceHttps flag in JsonSchemaFactory.Builder#400stevehu merged 2 commits intonetworknt:masterfrom PicnicSupermarket:hsener/gh-314
forceHttps flag in JsonSchemaFactory.Builder#400stevehu merged 2 commits intonetworknt:masterfrom
PicnicSupermarket:hsener/gh-314
Conversation
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
============================================
+ Coverage 70.76% 70.81% +0.05%
- Complexity 750 751 +1
============================================
Files 81 81
Lines 2894 2899 +5
Branches 593 594 +1
============================================
+ Hits 2048 2053 +5
Misses 624 624
Partials 222 222
Continue to review full report at Codecov.
|
Contributor
|
@hisener Thanks a lot for your help. |
Contributor
Author
|
@stevehu, is there a plan to cut a release soon? |
Contributor
|
@hisener 1.0.53 has been released a moment ago. Thank you again for your help. https://github.com/networknt/json-schema-validator/releases/tag/1.0.53 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In e32a541, schema normalization was introduced to fix #273 however it assumes the given schema is available over HTTPS.
json-schema-validator/src/main/java/com/networknt/schema/JsonSchemaFactory.java
Line 406 in e32a541
As reported in #314, some schemas are not available over HTTPS. For example, https://iglucentral.com (it just hangs with https), see snowplow/iglu-central#1067.
Therefore #314 blocks snowplow/iglu-scala-client#136 and our internal
json-schema-validatordependency upgrade from1.0.39to1.0.40+.The first commit in this PR provides a failing test for #314 and the second one introduces a boolean flag to control the URI scheme.
Fixes #314.