Skip to content

Adding walk capabilities to networknt. #336

Merged
stevehu merged 14 commits intonetworknt:masterfrom
prashanthjos:master
Oct 19, 2020
Merged

Adding walk capabilities to networknt. #336
stevehu merged 14 commits intonetworknt:masterfrom
prashanthjos:master

Conversation

@prashanthjos
Copy link
Copy Markdown
Member

@prashanthjos prashanthjos commented Oct 19, 2020

As discussed in the issue #316 , please have a look at the walk capability changes for networknt.

@prashanthjos
Copy link
Copy Markdown
Member Author

prashanthjos commented Oct 19, 2020

@stevehu please feel free to drop me an email if in doubt. We can discuss more about the changes through a meeting.

@stevehu
Copy link
Copy Markdown
Contributor

stevehu commented Oct 19, 2020

Wow! It is a big addition to the library and I like the document and flow picture. It will take some time for me and others to digest. I am sure I will have questions later. Meanwhile, would you be able to merge the latest master branch to your branch so that we can easily compare them? I also send you an invitation for the write access to the repo and you can move your contribution to a branch for easy collaboration if you like. Thanks.

@prashanthjos
Merge pull request #4 from networknt/master
a3c2e97 
Merging Changes from networknt repo.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 19, 2020

Codecov Report

Merging #336 into master will decrease coverage by 1.11%.
The diff coverage is 57.79%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #336      +/-   ##
============================================
- Coverage     70.97%   69.85%   -1.12%     
- Complexity      653      694      +41     
============================================
  Files            75       80       +5     
  Lines          2491     2737     +246     
  Branches        529      567      +38     
============================================
+ Hits           1768     1912     +144     
- Misses          520      612      +92     
- Partials        203      213      +10
Impacted Files Coverage Δ Complexity Δ
...main/java/com/networknt/schema/AllOfValidator.java 66.66% <0.00%> (-33.34%) 5.00 <0.00> (ø)
.../main/java/com/networknt/schema/JsonSchemaRef.java 83.33% <0.00%> (-7.58%) 4.00 <0.00> (ø)
...c/main/java/com/networknt/schema/NotValidator.java 68.75% <0.00%> (-31.25%) 4.00 <0.00> (ø)
...main/java/com/networknt/schema/OneOfValidator.java 70.40% <0.00%> (-4.60%) 11.00 <0.00> (ø)
...in/java/com/networknt/schema/PatternValidator.java 31.25% <0.00%> (-2.65%) 2.00 <0.00> (ø)
...main/java/com/networknt/schema/ItemsValidator.java 60.86% <7.14%> (-36.81%) 18.00 <0.00> (ø)
...c/main/java/com/networknt/schema/RefValidator.java 68.25% <22.22%> (-7.68%) 13.00 <0.00> (ø)
...etworknt/schema/AdditionalPropertiesValidator.java 70.14% <27.27%> (-20.97%) 18.00 <2.00> (+2.00) ⬇️
...a/com/networknt/schema/SchemaValidatorsConfig.java 61.70% <42.85%> (-27.78%) 14.00 <4.00> (+4.00) ⬇️
...va/com/networknt/schema/AbstractJsonValidator.java 53.84% <50.00%> (-1.71%) 4.00 <1.00> (+1.00) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03bf8ef...a3c2e97. Read the comment docs.

@prashanthjos
Copy link
Copy Markdown
Member Author

prashanthjos commented Oct 19, 2020

@stevehu I updated my fork master branch with latest changes from networknt master branch. We can compare the changes now easily in this PR. Also I created a new branch 'schema_walk_changes' where I have my latest changes. Please let me know if you need any further help in making the merge process easy.

@prashanthjos prashanthjos requested a review from stevehu October 19, 2020 17:34
stevehu
stevehu approved these changes Oct 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@stevehu stevehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the changes are massive, it is separated from the validator code with careful design. All existing test cases are working, which is an indicator that there would be no impact on the validation functionalities.

@stevehu stevehu merged commit 57bae55 into networknt:master Oct 19, 2020
@stevehu
Copy link
Copy Markdown
Contributor

stevehu commented Oct 19, 2020

@prashanthjos Please test internally and let me know if the feature is fixed. I will release it once we have your confirmation. Thanks.

@prashanthjos
Copy link
Copy Markdown
Member Author

prashanthjos commented Oct 20, 2020

@stevehu Thank you for merging the changes. Yes there is no impact to existing validations and validators. I have tested all the changes locally. This library can now walk or validate the JSON data for a given schema. Any further changes would be minor and can be fixed through small PR's if required. I would request you to create a new release and update the jar version, so that I can start using it.

@stevehu
Copy link
Copy Markdown
Contributor

stevehu commented Oct 20, 2020

1.0.44 is released.

@fdutton fdutton mentioned this pull request Jun 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevehu stevehu stevehu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prashanthjos @stevehu @codecov-io @prashanth-chaitanya