Add $comment as a NonValidationKeyword for v7 and v2019 drafts#328
Merged
stevehu merged 1 commit intonetworknt:masterfrom Oct 7, 2020
kmalski:master
Merged
Add $comment as a NonValidationKeyword for v7 and v2019 drafts#328stevehu merged 1 commit intonetworknt:masterfrom kmalski:master
stevehu merged 1 commit intonetworknt:masterfrom
kmalski:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
============================================
+ Coverage 70.79% 70.97% +0.18%
- Complexity 652 653 +1
============================================
Files 75 75
Lines 2496 2491 -5
Branches 529 529
============================================
+ Hits 1767 1768 +1
+ Misses 525 520 -5
+ Partials 204 203 -1
Continue to review full report at Codecov.
|
Contributor
|
I don't think we need a test case for this as long as you don't see the warning message from the log. Thanks a lot for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure I am able to test this change. I did not find out any idea how to do it 😄
You can find the reference to the schema here:
https://json-schema.org/understanding-json-schema/reference/generic.html#comments
and here:
https://json-schema.org/draft-07/json-schema-core.html#rfc.section.9