FIX: potential duplicate log entry due to race condition#323
Merged
stevehu merged 1 commit intonetworknt:masterfrom Aug 25, 2020
Merged
FIX: potential duplicate log entry due to race condition#323stevehu merged 1 commit intonetworknt:masterfrom
stevehu merged 1 commit intonetworknt:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
============================================
- Coverage 70.80% 70.79% -0.02%
Complexity 652 652
============================================
Files 75 75
Lines 2497 2496 -1
Branches 529 529
============================================
- Hits 1768 1767 -1
Misses 525 525
Partials 204 204
Continue to review full report at Codecov.
|
Contributor
|
@kkonrad Thanks a lot for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was potentially race condition that could lead to situation in which we could get multiple log entries regarding the same keyword being unknown. Such case was when more than one thread was doing check on
containsKeybefore they went intoput.Simple fix for this is to always add element to the
UNKNOWN_KEYWORDSmap and than check if it was present. See documentation forputmethod and what value it returns. Doing this that way shouldn't impact performance.